From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.179]) by ozlabs.org (Postfix) with ESMTP id A948867DFD for ; Fri, 10 Nov 2006 22:45:23 +1100 (EST) Received: by py-out-1112.google.com with SMTP id p76so315949pyb for ; Fri, 10 Nov 2006 03:45:22 -0800 (PST) Message-ID: Date: Fri, 10 Nov 2006 13:45:21 +0200 From: "Kalle Pokki" Sender: kallepokki@gmail.com To: "Paul Mackerras" Subject: Re: [PATCH] CPM_UART: Fix non-console initialisation (v2) In-Reply-To: <17748.21645.621069.105453@cargo.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <17748.21645.621069.105453@cargo.ozlabs.ibm.com> Cc: linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11/10/06, Paul Mackerras wrote: > > The last hunk, i.e. the change to drivers/serial/cpm_uart/cpm_uart_cpm2.c, > doesn't apply because cpm_uart_init_portdesc now looks different to the > context in your patch, so I dropped that hunk (it looked to be pretty > much independent of the other changes). OK, better drop all the hunks except the one that concerns drivers/serial/cpm_uart/cpm_uart_core.c then, since I added the same '__init' lines in cpm_uart.h, cpm_uart_cpm1.c, and cpm_uart_cpm2.c. > Also, the whitespace is damaged throughout this and your other > patches. I fixed it up this time, but please fix your mailer not to > munge the whitespace. Specifically, where a line begins with a space > character, your mailer removes it if there is nothing else on the > line, or turns it into two spaces otherwise. :P I'll fix this. It seems I was sending the patches with pine making them flowed.