From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.206]) by ozlabs.org (Postfix) with ESMTP id A899267DB1 for ; Mon, 13 Nov 2006 22:01:58 +1100 (EST) Received: by nz-out-0102.google.com with SMTP id v1so764387nzb for ; Mon, 13 Nov 2006 03:01:58 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2006 13:01:56 +0200 From: "Kalle Pokki" Sender: kallepokki@gmail.com To: "Paul Mackerras" Subject: Re: [PATCH] CPM_UART: Fix non-console initialisation (v2) In-Reply-To: <17752.16589.182362.143760@cargo.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <17748.21645.621069.105453@cargo.ozlabs.ibm.com> <17749.46096.241328.470093@cargo.ozlabs.ibm.com> <20061113112230.4c1af7b0@localhost.localdomain> <17752.16589.182362.143760@cargo.ozlabs.ibm.com> Cc: linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11/13/06, Paul Mackerras wrote: > Well, what I want to know is this: why was the addition of __init > bundled in with what I was told was a bug-fix that was needed for > 2.6.19? Does the addition of __init fix a bug somehow? That wasn't necessary, but the change was so small I thought we could just as well do it at the same time when touching this function anyway. (Although the second version of the patch didn't modify it anymore, thus making the part adding __init actually larger in the patch than the part having the bugfix.)