LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linuxppc-dev@lists.ozlabs.org,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	LKML <linux-kernel@vger.kernel.org>,
	Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: powernv: fix stack bloat and NR_CPUS limitation
Date: Thu, 17 Oct 2019 21:41:20 -0700	[thread overview]
Message-ID: <a4a1467f-2c92-34f2-a8bf-718feaa17da7@nvidia.com> (raw)
In-Reply-To: <20191018043856.srvgft6jhqw62bx3@vireshk-i7>

On 10/17/19 9:38 PM, Viresh Kumar wrote:
> On 17-10-19, 21:34, John Hubbard wrote:
>> On 10/17/19 9:27 PM, Viresh Kumar wrote:
>>> On 17-10-19, 17:04, John Hubbard wrote:
>>>> The following build warning occurred on powerpc 64-bit builds:
>>>>
>>>> drivers/cpufreq/powernv-cpufreq.c: In function 'init_chip_info':
>>>> drivers/cpufreq/powernv-cpufreq.c:1070:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>>>
>>> How come we are catching this warning after 4 years ?
>>>
>>
>> Newer compilers. And btw, I don't spend a lot of time in powerpc
>> code, so I just recently ran this, and I guess everyone has been on less
>> new compilers so far, it seems.
>>
>> I used a gcc 8.1 cross compiler in this case:
> 
> Hmm, okay.
> 
> I hope you haven't missed my actual review comments on your patch,
> just wanted to make sure we don't end up waiting for each other
> indefinitely here :)
> 

Ha, I did overlook those. It's late around here, I guess. :)

I'll send a v2 with those changes. 

thanks,

John Hubbard
NVIDIA

  reply	other threads:[~2019-10-18  4:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  0:04 [PATCH] cpufreq: powernv: fix stack bloat and NR_CPUS limitation John Hubbard
2019-10-18  4:27 ` Viresh Kumar
2019-10-18  4:34   ` John Hubbard
2019-10-18  4:38     ` Viresh Kumar
2019-10-18  4:41       ` John Hubbard [this message]
2019-10-18  4:50         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4a1467f-2c92-34f2-a8bf-718feaa17da7@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=rjw@rjwysocki.net \
    --cc=shilpa.bhat@linux.vnet.ibm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox