From: Segher Boessenkool <segher@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Alexandre Bounine <Alexandre.Bounine@tundra.com>,
David Gibson <dwg@au1.ibm.com>, Paul Mackerras <paulus@samba.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: Fix problems with Holly's DT representation of ethernet PHYs
Date: Tue, 29 May 2007 16:49:31 +0200 [thread overview]
Message-ID: <a5c459df2eefeb9261e65c551870f7f5@kernel.crashing.org> (raw)
In-Reply-To: <1180448346.3360.49.camel@zod.rchland.ibm.com>
>>> + compatible = "tsi-mdio";
>>
>> Hrm, did I miss this before? A more exact "compatible"
>> property would be better ("tsi109-mdio" "tsi108-mdio" or
>> something like that).
>
> If we must, then tsi108-mdio is what I would recommend. They are the
> same between 108, 109, and 110 as far as I know, so it's the lowest
> common denominator.
[Assuming what is really on the board is a tsi109...]
I recommend putting both 109 and 108 in the property, in
that order; that way, if you need to do something special
on the tsi109 implementation (something you might not yet
know about perhaps, maybe a bug; or some extra feature on
the tsi109 device that the driver doesn't handle yet), the
driver has a chance to do that. If the driver doesn't care
and only uses tsi108 features, it obviously can probe for
tsi108 only and all will be fine as well.
Segher
next prev parent reply other threads:[~2007-05-29 14:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 6:05 Fix problems with Holly's DT representation of ethernet PHYs David Gibson
2007-05-29 6:43 ` Segher Boessenkool
2007-05-29 14:19 ` Josh Boyer
2007-05-29 14:49 ` Segher Boessenkool [this message]
2007-05-29 19:29 ` Josh Boyer
2007-05-30 11:17 ` Benjamin Herrenschmidt
2007-05-30 11:32 ` David Gibson
2007-05-30 11:36 ` Segher Boessenkool
2007-05-30 13:48 ` Josh Boyer
2007-05-30 15:28 ` Segher Boessenkool
2007-05-31 5:54 ` Zang Roy-r61911
2007-05-30 1:26 ` David Gibson
-- strict thread matches above, loose matches on Subject: below --
2007-05-24 4:16 David Gibson
2007-05-24 4:22 ` Kumar Gala
2007-05-24 5:59 ` David Gibson
2007-05-24 9:13 ` Segher Boessenkool
2007-05-24 13:44 ` Josh Boyer
2007-05-25 4:23 ` David Gibson
2007-05-25 4:37 ` David Gibson
2007-05-25 4:38 ` David Gibson
2007-05-25 14:03 ` Josh Boyer
2007-05-27 23:36 ` David Gibson
2007-05-25 14:11 ` Segher Boessenkool
2007-05-27 23:30 ` David Gibson
2007-05-28 1:38 ` Benjamin Herrenschmidt
2007-05-28 11:07 ` Segher Boessenkool
2007-05-28 11:15 ` Benjamin Herrenschmidt
2007-05-28 11:06 ` Segher Boessenkool
2007-05-29 4:47 ` David Gibson
2007-05-24 9:11 ` Segher Boessenkool
2007-05-24 13:45 ` Josh Boyer
2007-05-25 2:04 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c459df2eefeb9261e65c551870f7f5@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=Alexandre.Bounine@tundra.com \
--cc=dwg@au1.ibm.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).