linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property
Date: Wed, 31 Aug 2022 09:26:17 +0200	[thread overview]
Message-ID: <a5d148c1-70c1-4e86-a50c-7dc6da45ff2f@www.fastmail.com> (raw)
In-Reply-To: <20220830230012.9429-1-pali@kernel.org>

On Wed, Aug 31, 2022, at 1:00 AM, Pali Rohár wrote:
> a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml 
> b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index da2509724812..4c8b0d0a0111 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -42,6 +42,11 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: The reset value written to the reboot register (32 
> bit access).
> 
> +  priority:
> +    $ref: /schemas/types.yaml#/definitions/int32
> +    description: Priority level of this syscon reset device.
> +    default: 192
> +

My first thought was that this is looks very Linux specific and
probably should be documented as such. However I see there is
already precedent in
Documentation/devicetree/bindings/power/reset/gpio-restart.yaml,
which defines the same thing with a more detailed description.

Since this is an optional property for both, and it has the
same meaning here, is it possible to move the description
to a common place where it either gets included from both,
or from all reboot bindings?

       Arnd

  parent reply	other threads:[~2022-08-31  7:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-20 10:29 [PATCH 1/3] dt-bindings: reset: syscon-reboot: Add priority property Pali Rohár
2022-08-20 10:29 ` [PATCH 2/3] power: reset: syscon-reboot: Add support for specifying priority Pali Rohár
2022-08-20 10:29 ` [PATCH 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2022-08-21 20:21 ` [PATCH 1/3] dt-bindings: reset: syscon-reboot: Add priority property Rob Herring
2022-08-22 12:47 ` Rob Herring
2022-08-22 13:50   ` Pali Rohár
2022-09-02 20:37     ` Rob Herring
2022-09-07 12:27       ` Krzysztof Kozlowski
2022-08-30 23:00 ` [PATCH v2 " Pali Rohár
2022-08-30 23:00   ` [PATCH v2 2/3] power: reset: syscon-reboot: Add support for specifying priority Pali Rohár
2022-08-30 23:00   ` [PATCH v2 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2022-08-31  7:26   ` Arnd Bergmann [this message]
2022-09-02 20:40     ` [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property Rob Herring
2022-08-31  7:31   ` Krzysztof Kozlowski
2022-08-31  7:36     ` Pali Rohár
2022-08-31  7:52       ` Krzysztof Kozlowski
2022-08-31  8:17 ` [PATCH v3 " Pali Rohár
2022-08-31  8:17   ` [PATCH v3 2/3] power: reset: syscon-reboot: Add support for specifying priority Pali Rohár
2022-08-31  8:17   ` [PATCH v3 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2022-09-07 12:38   ` [PATCH v3 1/3] dt-bindings: reset: syscon-reboot: Add priority property Krzysztof Kozlowski
2022-09-07 16:33     ` Pali Rohár
2022-09-08  7:26       ` Krzysztof Kozlowski
     [not found] ` <20221226114513.4569-1-pali@kernel.org>
2022-12-26 11:45   ` [PATCH v4 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2023-02-09  0:10     ` Pali Rohár
2023-02-18 12:05       ` Pali Rohár
2023-02-20  0:55         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5d148c1-70c1-4e86-a50c-7dc6da45ff2f@www.fastmail.com \
    --to=arnd@arndb.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).