From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6C17C43458 for ; Mon, 13 Jul 2026 11:31:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gzKyd0Gp4z2yMm; Mon, 13 Jul 2026 21:31:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783942296; cv=none; b=hMjbl19en13Wa36IqvNAOV0uNmXZcqv76dTFebCrnewc+zyWIPUZnFpGOgjeOFmhF+/w2uXwAz0ljRzpirjU4Pf9v9HGXgNYUgDy9TtKglaEGOeSI9y8KTLHuVerU1a+vrUNLwIdXESJyni9ZxNO33U2AkXyx7lOffJM1yMO6toeI8VTL2nUiFCQVtUxZYrY4/TNSEPosG6ubiVqy77sxTV4Q20TigLpsSHRJtdDdXUDjtJ06DgihoGgT1/54HUCDyCpdcJF+cbj45yqPV/SmAiNBaXS4u4UxzncHEAAUuMgTfcdnXWsxQM7RobxFBpxOUPyrp3M9h6eA7gUJJx0hQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783942296; c=relaxed/relaxed; bh=291z0iMy6ACy4umd+5gN9PHfheorz4UXB4xEyqm+dHY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RZeA2bMbK8ml98m8c2BA3qragOGQMqFhqan1Xv+PRQOSRoUsHkQZCXvDygZOoiA/eXvaJZ2/dsFeLScWTRhXSjg3fYtWen4QOnVhE67/+Y0N7QHGg6M9wx5QXEX7i3JFWNrsaYaXqjbRNz7sbi+NUVBKWysEZAjn5sHC/3JLARACnRKChUKkkJYuSqjw5qoS9Wey5HhJJvQQUbTQmuOvFfW9QT/hvo6Tq2R7xjHDQNg+B0ws5foH0hYRweF4h8Wk5l7t/+mwjLouvOb0kby22gMyY7AqMGSQ8Wb7abMZ/96vk1kKCf0ggbUcQwDGcd5kKaJMYp9LU5veMrVm1v5JwQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=NFZq0nT6; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=sourabhjain@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=NFZq0nT6; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=sourabhjain@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gzKyb4NG5z2xlv for ; Mon, 13 Jul 2026 21:31:34 +1000 (AEST) Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6g7tj1732367; Mon, 13 Jul 2026 11:31:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=291z0i My6ACy4umd+5gN9PHfheorz4UXB4xEyqm+dHY=; b=NFZq0nT64XkNedVp2mXpkF NNcyBfJkpAtKROEnPirAHadXIX1DXXSxwrXFkYtvQBbsvk4RZ830+dwCLBtJOz/Y q0RDoKuHDXOl0nuDOwIC8P+6Mu5Z6AX0skkMYd1PQ6D3NvCg5eYLW468ScZKYG9d AfqgwFtB4yIjHBj9s8SOvklEem2t8L65Uvgjxe3UykVGZX9BpN4Nhr6z/eEwRpHy 6ImeWJg2i5q95ypErjwuQ5vMRG6MUbpfDlVOaXvanfFjizeTi900TskiqCbJNCpJ WEoaMMywIRd0dQsKgPEQ3/GRdOmkgBG9zdG8K0DnOU1dRTR6sr22RQaNmnBrfczg == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fbegbg12a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jul 2026 11:31:23 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66DBJZVd003984; Mon, 13 Jul 2026 11:31:22 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4fc2cg566c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jul 2026 11:31:22 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66DBVIBQ45023666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jul 2026 11:31:18 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 64F0E20040; Mon, 13 Jul 2026 11:31:18 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CDF1520065; Mon, 13 Jul 2026 11:31:15 +0000 (GMT) Received: from [9.123.14.142] (unknown [9.123.14.142]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 13 Jul 2026 11:31:15 +0000 (GMT) Message-ID: Date: Mon, 13 Jul 2026 17:00:33 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] powerpc/crash: protect kdump from active watchdogs To: "Ritesh Harjani (IBM)" , linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, mpe@ellerman.id.au Cc: npiggin@gmail.com, chleroy@kernel.org, shivangu@linux.ibm.com, hbathini@linux.ibm.com, mahesh@linux.ibm.com, adityag@linux.ibm.com, venkat88@linux.ibm.com, stable@vger.kernel.org References: <20260713035954.1559605-1-sourabhjain@linux.ibm.com> <91e04278-aa90-4cbc-aeb4-f4663bf1f058@linux.ibm.com> Content-Language: en-US From: Sourabh Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=fOcJG5ae c=1 sm=1 tr=0 ts=6a54cc8b cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=VwQbUJbxAAAA:8 a=cAh3PJzBWdOWiawSA5MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDExNiBTYWx0ZWRfXyFuHFQ31p+z/ C6EH7EwaVouCanqpcEB3Qk5wqoiLIBcVOp0eZOCMADOp1nKPbZSE5eKSiFH1ruBg8kczUQv1d26 xXUUC6d/rtdF37wdsogVSxU084yuNZUOo3+cUTEGIuqV2czj23Y8vKWQ9fKIQhaDt29JBbaAb5Y dL2kXOjUNKzzkZc0EaNcAww8WE/kClwoBH6q2E5CAveVDekTdFXO+3MK9db49r7ZkefChm33007 PKFLncTLefcCJtrY1kWbWgYs0UJHs1jwd5X5JHDbuhpFmf/uliEXQeKwHlinUZDAfwwW4ImAo1a puP8T32XgY655rZkjQwpZdSam0+PzpgvTTkV/r4LD2xZhI/pdMnmBLIMYn8SbbRSQy1Ae2izqTt Vgu/sIUvz6fV0+sI5MJpWVPgLMm+91pZTQZuzAFwFY/JlLJAVfi/ndbuYCp18tnlnD+A+dW5JXd F2tsU065dVLDYQxCFQw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDExNiBTYWx0ZWRfX9zzHD1JtMzDg DkX4H0AoeQvdZDu5kDiBefEycNkO12CmnJP91HdcKd4r92PNjndycDQARMUvJzeDltwe64WEfam 1wHecTJEPnPBPAu12MOEN6dVlwt84cQ= X-Proofpoint-GUID: QUZmTu88xlQjl44bX-V08oYhYM9Ha9lb X-Proofpoint-ORIG-GUID: OtDU0bq9Lo8498ENEvjsZ6iwpt4n7laq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 impostorscore=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130116 On 13/07/26 12:10, Ritesh Harjani (IBM) wrote: > Sourabh Jain writes: > >> On 13/07/26 10:51, Ritesh Harjani (IBM) wrote: >>> Sourabh Jain writes: >>> >>>> Changelog: >>>> ========== >>>> >>>> v2: >>>> - Move H_WATCHDOG definitions to a common header for shared use >>>> across pseries code. 1/3 >>>> - Added a new patch to handle pseries watchdog device registration >>>> failure. 2/3 >>>> - Stop active watchdogs in crash hanlder. 3/3 Ritesh >>>> - Add suggested-by tag 1/3 & 3/3 >>> Reviewed the changes and mostly looks good with some minor nits added to >>> the individual patches. >>> >>> Small request - >>> Could you please also update test results with v3 in your changelog >>> (since you mentioned we are able to reproduce the issue easily with your >>> test code). >> I tested this fix with the program I shared in cover letter. The watchdog >> was successfully stopped even when H_WATCHDOG is called form crash >> handler.  I will share my test details in v3 cover letter also. >> >>> >>> aah one other thing I just noticed since you are ccing stable and you >>> added a Fixes tag in patch-3. >>> Patch-3 alone cannot be easily backported now due to patch-1 and >>> patch-2. There must be a way to define the dependencies if you are >>> looking for backporting the fix patch to stable tree, please check that >>> and follow that accordingly in v3. >> I thought about that as well, but since they are part of the same patch >> series, >> I assumed they would be picked together. However, I don't think that >> will work >> in all cases. >> >> I checked the older commits and noticed that a backport note was added. >> I think >> we can do the same for the fix patch. I'll add a note indicating that the >> following patches should be backported first: >> >> powerpc/pseries: Move H_WATCHDOG definitions to a common header >> powerpc/pseries: Handle and log pseries-wdt registration failures >> >> Since these patches are not upstream yet, I'll refer to them by their >> commit titles. >> >> Does that look good to you? >> > Documentation/process/stable-kernel-rules.rst > Note that for a patch series, you do not have to list as prerequisites the > patches present in the series itself. For example, if you have the following > patch series:: > > patch1 > patch2 > > where patch2 depends on patch1, you do not have to list patch1 as > prerequisite of patch2 if you have already marked patch1 for stable > inclusion. > > > In that case, I think, we should mark all 3 patches for stable inclusion. > > patch 1/3 Cc: stable@vger.kernel.org > patch 2/3 Cc: stable@vger.kernel.org > patch 3/3 Cc: stable@vger.kernel.org > Fixes: 69472ffa6575 ("watchdog/pseries-wdt: initial support for H_WATCHDOG-based watchdog timers" Okay, for stable tree inclusion, CCing is enough. Thanks Sourabh Jain