From: Michael Bringmann <mwb@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Michael Bringmann <mwb@linux.vnet.ibm.com>,
John Allen <jallen@linux.vnet.ibm.com>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>
Subject: [PATCH 2/2] powerpc/hotplug: Ensure nodes initialized for hotplug
Date: Mon, 18 Sep 2017 13:28:41 -0500 [thread overview]
Message-ID: <a5f7fdb2-d974-03c6-5ecc-c7f726f2b244@linux.vnet.ibm.com> (raw)
In-Reply-To: <49626c85-d466-3f99-bde8-f459e278f6ee@linux.vnet.ibm.com>
powerpc/hotplug: On systems like PowerPC which allow 'hot-add' of CPU,
it may occur that the new resources are to be inserted into nodes
that were not used for memory resources at bootup. Many different
configurations of PowerPC resources may need to be supported depending
upon the environment. This patch fixes some problems encountered at
runtime with configurations that support memory-less nodes, but which
allow CPUs to be added at and after boot.
Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
---
arch/powerpc/mm/numa.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index b385cd0..e811dd1 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -551,7 +551,7 @@ static int numa_setup_cpu(unsigned long lcpu)
nid = of_node_to_nid_single(cpu);
out_present:
- if (nid < 0 || !node_online(nid))
+ if (nid < 0 || !node_possible(nid))
nid = first_online_node;
map_cpu_to_node(lcpu, nid);
@@ -1325,6 +1325,17 @@ static long vphn_get_associativity(unsigned long cpu,
return rc;
}
+static int verify_node_preparation(int nid)
+{
+ if ((NODE_DATA(nid) == NULL) ||
+ (NODE_DATA(nid)->node_spanned_pages == 0)) {
+ if (try_online_node(nid))
+ return first_online_node;
+ }
+
+ return nid;
+}
+
/*
* Update the CPU maps and sysfs entries for a single CPU when its NUMA
* characteristics change. This function doesn't perform any locking and is
@@ -1433,9 +1444,11 @@ int numa_update_cpu_topology(bool cpus_locked)
/* Use associativity from first thread for all siblings */
vphn_get_associativity(cpu, associativity);
new_nid = associativity_to_nid(associativity);
- if (new_nid < 0 || !node_online(new_nid))
+ if (new_nid < 0 || !node_possible(new_nid))
new_nid = first_online_node;
+ new_nid = verify_node_preparation(new_nid);
+
if (new_nid == numa_cpu_lookup_table[cpu]) {
cpumask_andnot(&cpu_associativity_changes_mask,
&cpu_associativity_changes_mask,
next prev parent reply other threads:[~2017-09-18 18:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 18:28 [PATCH 0/2] powerpc/nodes/hotplug: Fix problem with memoryless nodes Michael Bringmann
2017-09-18 18:28 ` [PATCH 1/2] powerpc/nodes: Ensure enough nodes avail for operations Michael Bringmann
2017-10-16 12:33 ` Michael Ellerman
2017-10-17 16:14 ` Michael Bringmann
2017-10-17 17:02 ` Nathan Fontenot
2017-10-17 17:22 ` Michael Bringmann
2017-10-17 17:41 ` Nathan Fontenot
2017-09-18 18:28 ` Michael Bringmann [this message]
2017-10-16 12:54 ` [PATCH 2/2] powerpc/hotplug: Ensure nodes initialized for hotplug Michael Ellerman
2017-10-17 15:08 ` Michael Bringmann
2017-11-15 18:28 ` Michael Bringmann
2017-11-16 16:57 ` Nathan Fontenot
2017-11-16 17:36 ` Michael Bringmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f7fdb2-d974-03c6-5ecc-c7f726f2b244@linux.vnet.ibm.com \
--to=mwb@linux.vnet.ibm.com \
--cc=jallen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).