From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: nicoleotsuka@gmail.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, Xiubo.Lee@gmail.com,
linux-kernel@vger.kernel.org,
Shengjiu Wang <shengjiu.wang@nxp.com>,
tiwai@suse.com, linux-media@vger.kernel.org, tfiga@chromium.org,
hverkuil@xs4all.nl, linuxppc-dev@lists.ozlabs.org,
broonie@kernel.org, sakari.ailus@iki.fi, perex@perex.cz,
mchehab@kernel.org, festevam@gmail.com, m.szyprowski@samsung.com
Subject: Re: [PATCH v9 14/15] media: imx-asrc: Add memory to memory driver
Date: Thu, 16 Nov 2023 12:15:21 +0100 [thread overview]
Message-ID: <a6e39566-f872-4bae-83e4-212e75e705dc@kernel.org> (raw)
In-Reply-To: <CAA+D8ANiNr0DVNP4eiTGVzvYGxTJJBjJocW++x0A9GDEbNTqRA@mail.gmail.com>
On 16/11/2023 09:32, Shengjiu Wang wrote:
>>> +MODULE_DESCRIPTION("Freescale ASRC M2M driver");
>>> +MODULE_ALIAS("platform:" M2M_DRV_NAME);
>>
>> You should not need MODULE_ALIAS() in normal cases. If you need it,
>> usually it means your device ID table is wrong (e.g. misses either
>> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
>> for incomplete ID table.
>
>
> This driver don't have MODULE_DEVICE_TABLE. it is only registered
> by platform_device_register_data().
Which is the problem. I thought I made myself clear but if it is not the
case: drop MODULE_ALIAS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-16 11:16 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 5:47 [PATCH v9 00/15] Add audio support in v4l2 framework Shengjiu Wang
2023-11-10 5:47 ` [PATCH v9 01/15] ASoC: fsl_asrc: define functions for memory to memory usage Shengjiu Wang
2023-11-10 5:47 ` [PATCH v9 02/15] ASoC: fsl_easrc: " Shengjiu Wang
2023-11-10 5:47 ` [PATCH v9 03/15] ASoC: fsl_asrc: move fsl_asrc_common.h to include/sound Shengjiu Wang
2023-11-10 5:47 ` [PATCH v9 04/15] ASoC: fsl_asrc: register m2m platform device Shengjiu Wang
2023-11-10 5:47 ` [PATCH v9 05/15] ASoC: fsl_easrc: " Shengjiu Wang
2023-11-10 5:48 ` [PATCH v9 06/15] media: uapi: Add V4L2_CAP_AUDIO_M2M capability flag Shengjiu Wang
2023-11-10 5:48 ` [PATCH v9 07/15] media: v4l2: Add audio capture and output support Shengjiu Wang
2023-11-13 9:54 ` Hans Verkuil
2023-11-10 5:48 ` [PATCH v9 08/15] media: uapi: Define audio sample format fourcc type Shengjiu Wang
2023-11-10 5:48 ` [PATCH v9 09/15] media: uapi: Add V4L2_CTRL_CLASS_M2M_AUDIO Shengjiu Wang
2023-11-10 5:48 ` [PATCH v9 10/15] media: uapi: Add V4L2_CTRL_TYPE_FIXED_POINT Shengjiu Wang
2023-11-13 10:29 ` Hans Verkuil
2023-11-13 10:42 ` Laurent Pinchart
2023-11-13 10:56 ` Hans Verkuil
2023-11-13 11:07 ` Laurent Pinchart
2023-11-13 11:24 ` Hans Verkuil
2023-11-13 11:28 ` Sakari Ailus
2023-11-13 11:43 ` Laurent Pinchart
2023-11-13 12:05 ` Hans Verkuil
2023-11-13 12:44 ` Laurent Pinchart
2023-11-15 8:09 ` Hans Verkuil
2023-11-15 8:45 ` Tomasz Figa
2023-11-15 9:13 ` Hans Verkuil
2023-11-15 10:55 ` Laurent Pinchart
2023-11-15 11:19 ` Hans Verkuil
2023-11-15 11:49 ` Laurent Pinchart
2023-11-16 7:31 ` Tomasz Figa
2023-11-16 8:01 ` Hans Verkuil
2023-11-16 9:15 ` Shengjiu Wang
2023-11-17 12:07 ` Hans Verkuil
2023-11-17 12:55 ` Laurent Pinchart
2023-11-17 13:07 ` Sakari Ailus
2023-11-17 14:05 ` Hans Verkuil
2023-11-20 8:30 ` Shengjiu Wang
2023-11-17 12:37 ` Laurent Pinchart
2023-11-15 8:22 ` Hans Verkuil
2023-11-10 5:48 ` [PATCH v9 11/15] media: uapi: Add audio rate controls support Shengjiu Wang
2023-11-10 5:48 ` [PATCH v9 12/15] media: uapi: Declare interface types for Audio Shengjiu Wang
2023-11-10 23:14 ` kernel test robot
2023-11-10 5:48 ` [PATCH v9 13/15] media: uapi: Add an entity type for audio resampler Shengjiu Wang
2023-11-11 10:52 ` kernel test robot
2023-11-10 5:48 ` [PATCH v9 14/15] media: imx-asrc: Add memory to memory driver Shengjiu Wang
2023-11-10 8:54 ` Hans Verkuil
2023-11-11 8:16 ` Krzysztof Kozlowski
2023-11-16 8:32 ` Shengjiu Wang
2023-11-16 11:15 ` Krzysztof Kozlowski [this message]
2023-11-10 5:48 ` [PATCH v9 15/15] media: vim2m-audio: add virtual driver for audio memory to memory Shengjiu Wang
2023-11-11 0:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6e39566-f872-4bae-83e4-212e75e705dc@kernel.org \
--to=krzk@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=sakari.ailus@iki.fi \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tfiga@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).