From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Jin Zhengxiong" <Jason.Jin@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4 V2] booting-without-of for Freescale MSI
Date: Fri, 9 May 2008 12:13:37 +0200 [thread overview]
Message-ID: <a7387ce0860d7d5bcd990f1364310221@kernel.crashing.org> (raw)
In-Reply-To: <CC27DED0F8F39E48A7E75FD768688B7A8C16ED@zch01exm27.fsl.freescale.net>
>> If these MSI devices work really identical for 83xx, 85xx,
>> 86xx, there is no need to distinguish between them for
>> probing either -- you want to use the same driver for all, anyway
> .
> The driver can work for 83xx, 85xx and 86xx, but the msiir offset
> is different for 83xx and 85xx/86xx cpu. I need this to get different
> msiir offset in the driver.
It's a different offset _within_ the region specified in "reg"?
Yeah, using different "compatible" is cleanest then, no doubt.
>>> + - msi-available-ranges: use <start count> style
>> section to define
>>> which
>>> + msi interrupt can be used in the 256 msi interrupts.
>>
>> Please make this property optional, default to "all available".
>>
> The value setting for this property is "all available", and this ranges
> maybe
> useful for some other MSI controller.
Sure, I didn't say to drop the property, just make it optional,
since most trees will want the same value anyway.
Segher
next prev parent reply other threads:[~2008-05-09 10:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 9:03 [PATCH 1/4 V2] booting-without-of for Freescale MSI Jason Jin
2008-05-09 9:03 ` [PATCH 2/4 V4] MSI support on 83xx/85xx/86xx board Jason Jin
2008-05-09 12:21 ` Michael Ellerman
2008-05-13 2:18 ` Jin Zhengxiong
2008-05-09 13:31 ` Grant Likely
2008-05-09 9:26 ` [PATCH 1/4 V2] booting-without-of for Freescale MSI Segher Boessenkool
2008-05-09 9:52 ` Jin Zhengxiong
2008-05-09 10:13 ` Segher Boessenkool [this message]
2008-05-09 10:18 ` Jin Zhengxiong
2008-05-09 10:51 ` Segher Boessenkool
2008-05-09 13:25 ` Grant Likely
2008-05-13 2:31 ` Jin Zhengxiong
2008-05-09 13:34 ` Grant Likely
2008-05-09 16:18 ` Timur Tabi
2008-05-09 16:24 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7387ce0860d7d5bcd990f1364310221@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=Jason.Jin@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).