From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0DC2FDDE00 for ; Fri, 9 May 2008 20:14:03 +1000 (EST) In-Reply-To: References: <1210323810-24833-1-git-send-email-Jason.jin@freescale.com> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: From: Segher Boessenkool Subject: Re: [PATCH 1/4 V2] booting-without-of for Freescale MSI Date: Fri, 9 May 2008 12:13:37 +0200 To: "Jin Zhengxiong" Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >> If these MSI devices work really identical for 83xx, 85xx, >> 86xx, there is no need to distinguish between them for >> probing either -- you want to use the same driver for all, anyway > . > The driver can work for 83xx, 85xx and 86xx, but the msiir offset > is different for 83xx and 85xx/86xx cpu. I need this to get different > msiir offset in the driver. It's a different offset _within_ the region specified in "reg"? Yeah, using different "compatible" is cleanest then, no doubt. >>> + - msi-available-ranges: use style >> section to define >>> which >>> + msi interrupt can be used in the 256 msi interrupts. >> >> Please make this property optional, default to "all available". >> > The value setting for this property is "all available", and this ranges > maybe > useful for some other MSI controller. Sure, I didn't say to drop the property, just make it optional, since most trees will want the same value anyway. Segher