From: Pasha Tatashin <pasha.tatashin@oracle.com>
To: Will Deacon <will.deacon@arm.com>, ard.biesheuvel@linaro.org
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
x86@kernel.org, kasan-dev@googlegroups.com,
borntraeger@de.ibm.com, heiko.carstens@de.ibm.com,
davem@davemloft.net, willy@infradead.org, mhocko@kernel.org,
catalin.marinas@arm.com, sam@ravnborg.org
Subject: Re: [v6 11/15] arm64/kasan: explicitly zero kasan shadow memory
Date: Tue, 8 Aug 2017 08:49:55 -0400 [thread overview]
Message-ID: <a777718a-00b5-fb3a-75d6-03cc7ad181d9@oracle.com> (raw)
In-Reply-To: <20170808123042.GG13355@arm.com>
Hi Will,
> Damn, I actually prefer the flag :)
>
> But actually, if you look at our implementation of vmemmap_populate,
then we
> have our own version of vmemmap_populate_basepages that terminates at the
> pmd level anyway if ARM64_SWAPPER_USES_SECTION_MAPS. If there's
resistance
> to do this in the core code, then I'd be inclined to replace our
> vmemmap_populate implementation in the arm64 code with a single
version that
> can terminate at either the PMD or the PTE level, and do zeroing if
> required. We're already special-casing it, so we don't really lose
anything
> imo.
Another approach is to create a new mapping interface for kasan only. As
what Ard Biesheuvel wrote:
> KASAN uses vmemmap_populate as a convenience: kasan has nothing to do
> with vmemmap, but the function already existed and happened to do what
> KASAN requires.
>
> Given that that will no longer be the case, it would be far better to
> stop using vmemmap_populate altogether, and clone it into a KASAN
> specific version (with an appropriate name) with the zeroing folded
> into it.
I agree with this statement, but I think it should not be part of this
project.
Pasha
next prev parent reply other threads:[~2017-08-08 12:52 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 20:38 [v6 00/15] complete deferred page initialization Pavel Tatashin
2017-08-07 20:38 ` [v6 01/15] x86/mm: reserve only exiting low pages Pavel Tatashin
2017-08-11 8:07 ` Michal Hocko
2017-08-11 15:24 ` Pasha Tatashin
2017-08-14 11:40 ` Michal Hocko
2017-08-14 13:30 ` Pasha Tatashin
2017-08-14 13:55 ` Michal Hocko
2017-08-17 15:37 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 02/15] x86/mm: setting fields in deferred pages Pavel Tatashin
2017-08-11 9:02 ` Michal Hocko
2017-08-11 15:39 ` Pasha Tatashin
2017-08-14 11:43 ` Michal Hocko
2017-08-14 13:32 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 03/15] sparc64/mm: " Pavel Tatashin
2017-08-07 20:38 ` [v6 04/15] mm: discard memblock data later Pavel Tatashin
2017-08-11 9:32 ` Michal Hocko
2017-08-11 9:50 ` Mel Gorman
2017-08-11 15:49 ` Pasha Tatashin
2017-08-11 16:04 ` Michal Hocko
2017-08-11 16:22 ` Pasha Tatashin
2017-08-14 11:36 ` Michal Hocko
2017-08-14 13:35 ` Pasha Tatashin
2017-08-11 19:00 ` Pasha Tatashin
2017-08-14 11:34 ` Michal Hocko
2017-08-14 13:39 ` Pasha Tatashin
2017-08-14 13:42 ` Michal Hocko
2017-08-07 20:38 ` [v6 05/15] mm: don't accessed uninitialized struct pages Pavel Tatashin
2017-08-11 9:37 ` Michal Hocko
2017-08-11 15:55 ` Pasha Tatashin
2017-08-14 11:47 ` Michal Hocko
2017-08-14 13:51 ` Pasha Tatashin
2017-08-17 15:28 ` Pasha Tatashin
2017-08-17 15:43 ` Michal Hocko
2017-08-15 9:33 ` Michal Hocko
2017-08-07 20:38 ` [v6 06/15] sparc64: simplify vmemmap_populate Pavel Tatashin
2017-08-07 20:38 ` [v6 07/15] mm: defining memblock_virt_alloc_try_nid_raw Pavel Tatashin
2017-08-11 12:39 ` Michal Hocko
2017-08-11 15:58 ` Pasha Tatashin
2017-08-11 16:06 ` Michal Hocko
2017-08-11 16:24 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 08/15] mm: zero struct pages during initialization Pavel Tatashin
2017-08-11 12:50 ` Michal Hocko
2017-08-11 16:03 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 09/15] sparc64: optimized struct page zeroing Pavel Tatashin
2017-08-11 12:53 ` Michal Hocko
2017-08-11 16:04 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 10/15] x86/kasan: explicitly zero kasan shadow memory Pavel Tatashin
2017-08-07 20:38 ` [v6 11/15] arm64/kasan: " Pavel Tatashin
2017-08-08 9:07 ` Will Deacon
2017-08-08 11:49 ` Pasha Tatashin
2017-08-08 12:30 ` Will Deacon
2017-08-08 12:49 ` Pasha Tatashin [this message]
2017-08-08 13:15 ` David Laight
2017-08-08 13:30 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 12/15] mm: explicitly zero pagetable memory Pavel Tatashin
2017-08-07 20:38 ` [v6 13/15] mm: stop zeroing memory during allocation in vmemmap Pavel Tatashin
2017-08-11 13:04 ` Michal Hocko
2017-08-11 16:11 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 14/15] mm: optimize early system hash allocations Pavel Tatashin
2017-08-11 13:05 ` Michal Hocko
2017-08-11 16:13 ` Pasha Tatashin
2017-08-07 20:38 ` [v6 15/15] mm: debug for raw alloctor Pavel Tatashin
2017-08-11 13:08 ` Michal Hocko
2017-08-11 16:18 ` Pasha Tatashin
2017-08-14 11:50 ` Michal Hocko
2017-08-14 14:01 ` Pasha Tatashin
2017-08-15 9:36 ` Michal Hocko
2017-08-11 7:58 ` [v6 00/15] complete deferred page initialization Michal Hocko
2017-08-11 15:13 ` Pasha Tatashin
2017-08-11 15:22 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a777718a-00b5-fb3a-75d6-03cc7ad181d9@oracle.com \
--to=pasha.tatashin@oracle.com \
--cc=ard.biesheuvel@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).