From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.235]) by ozlabs.org (Postfix) with ESMTP id 4A3F3DDEAB for ; Tue, 15 May 2007 10:17:36 +1000 (EST) Received: by wx-out-0506.google.com with SMTP id s19so1773935wxc for ; Mon, 14 May 2007 17:17:35 -0700 (PDT) Message-ID: Date: Tue, 15 May 2007 05:47:34 +0530 From: "Satyam Sharma" To: "Kumar Gala" Subject: Re: [PATCH 1/2] kbuild: Add "Section mismatch" warning whitelist for powerpc In-Reply-To: <3DF58590-DFD9-4665-8C47-33F407AAD1E7@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <46483FAC.60503@freescale.com> <20070514110636.GB10143@uranus.ravnborg.org> <3DF58590-DFD9-4665-8C47-33F407AAD1E7@kernel.crashing.org> Cc: Andrew Morton , Sam Ravnborg , Linux Kernel , linuxppc-dev@ozlabs.org, Li Yang , Linus List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On 5/14/07, Kumar Gala wrote: > > On May 14, 2007, at 6:06 AM, Sam Ravnborg wrote: > > > On Mon, May 14, 2007 at 06:53:32PM +0800, Li Yang wrote: > >> This patch fixes the following "Section mismatch" warnings when > >> build powerpc platforms. > >> > >> ------------- > >> WARNING: arch/powerpc/mm/built-in.o - Section mismatch: reference to > >> .init.text:early_get_page from .text between > >> 'pte_alloc_one_kernel' (at > >> offset 0xc68) and 'pte_alloc_one' > >> WARNING: mm/built-in.o - Section mismatch: reference to > >> .init.text:set_up_list3s from .text between > >> 'kmem_cache_create' (at offset > >> 0x20300) and 'cache_reap' > >> ------------- > > This warnings should be handled by __init_refok instead. Actually, once __init_refok comes in, would we need any other whitelisting mechanism at all? I think the exception patterns in secref_whitelist() and those two other whitelisting functions (init_section_ref_ok and exit_section_ref_ok) could all be subsumed and made redundant if / when __init_refok is used in the actual sources. Satyam