* [PATCH] cxl: Rework error message for incompatible slots
@ 2020-04-07 11:56 Frederic Barrat
2020-04-08 2:13 ` Andrew Donnellan
2020-09-09 13:37 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Frederic Barrat @ 2020-04-07 11:56 UTC (permalink / raw)
To: linuxppc-dev, christophe_lombard, ajd; +Cc: stable
Improve the error message shown if a capi adapter is plugged on a
capi-incompatible slot directly under the PHB (no intermediate switch).
Fixes: 5632874311db ("cxl: Add support for POWER9 DD2")
Cc: stable@vger.kernel.org # 4.14+
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
---
drivers/misc/cxl/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 25a9dd9c0c1b..2ba899f5659f 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -393,8 +393,8 @@ int cxl_calc_capp_routing(struct pci_dev *dev, u64 *chipid,
*capp_unit_id = get_capp_unit_id(np, *phb_index);
of_node_put(np);
if (!*capp_unit_id) {
- pr_err("cxl: invalid capp unit id (phb_index: %d)\n",
- *phb_index);
+ pr_err("cxl: No capp unit found for PHB[%lld,%d]. Make sure the adapter is on a capi-compatible slot\n",
+ *chipid, *phb_index);
return -ENODEV;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cxl: Rework error message for incompatible slots
2020-04-07 11:56 [PATCH] cxl: Rework error message for incompatible slots Frederic Barrat
@ 2020-04-08 2:13 ` Andrew Donnellan
2020-04-08 7:09 ` Frederic Barrat
2020-09-09 13:37 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Donnellan @ 2020-04-08 2:13 UTC (permalink / raw)
To: Frederic Barrat, linuxppc-dev, christophe_lombard; +Cc: stable
On 7/4/20 9:56 pm, Frederic Barrat wrote:
> Improve the error message shown if a capi adapter is plugged on a
> capi-incompatible slot directly under the PHB (no intermediate switch).
>
> Fixes: 5632874311db ("cxl: Add support for POWER9 DD2")
> Cc: stable@vger.kernel.org # 4.14+
> Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Seems fine to me, not sure if it needs to go to stable but I suppose
this could be causing actual confusion out in the field?
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cxl: Rework error message for incompatible slots
2020-04-08 2:13 ` Andrew Donnellan
@ 2020-04-08 7:09 ` Frederic Barrat
0 siblings, 0 replies; 4+ messages in thread
From: Frederic Barrat @ 2020-04-08 7:09 UTC (permalink / raw)
To: Andrew Donnellan, linuxppc-dev, christophe_lombard; +Cc: stable
Le 08/04/2020 à 04:13, Andrew Donnellan a écrit :
> On 7/4/20 9:56 pm, Frederic Barrat wrote:
>> Improve the error message shown if a capi adapter is plugged on a
>> capi-incompatible slot directly under the PHB (no intermediate switch).
>>
>> Fixes: 5632874311db ("cxl: Add support for POWER9 DD2")
>> Cc: stable@vger.kernel.org # 4.14+
>> Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
>
> Seems fine to me, not sure if it needs to go to stable but I suppose
> this could be causing actual confusion out in the field?
Yes it does. The reason for this patch is it was hit by a customer.
Fred
> Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: Rework error message for incompatible slots
2020-04-07 11:56 [PATCH] cxl: Rework error message for incompatible slots Frederic Barrat
2020-04-08 2:13 ` Andrew Donnellan
@ 2020-09-09 13:37 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-09-09 13:37 UTC (permalink / raw)
To: ajd, christophe_lombard, Frederic Barrat, linuxppc-dev; +Cc: stable
On Tue, 7 Apr 2020 13:56:01 +0200, Frederic Barrat wrote:
> Improve the error message shown if a capi adapter is plugged on a
> capi-incompatible slot directly under the PHB (no intermediate switch).
Applied to powerpc/next.
[1/1] cxl: Rework error message for incompatible slots
https://git.kernel.org/powerpc/c/40ac790d99c6dd16b367d5c2339e446a5f1b0593
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-09 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-07 11:56 [PATCH] cxl: Rework error message for incompatible slots Frederic Barrat
2020-04-08 2:13 ` Andrew Donnellan
2020-04-08 7:09 ` Frederic Barrat
2020-09-09 13:37 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).