From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D83FDEB64DC for ; Sat, 1 Jul 2023 05:47:20 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=un+mTFpR; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QtLml01dnz3c2T for ; Sat, 1 Jul 2023 15:47:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=un+mTFpR; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=rdunlap@infradead.org; receiver=lists.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QtLlm5Mq2z307d for ; Sat, 1 Jul 2023 15:46:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=gsaHjVQr2zvDdc7XvtO8GxLsgjI16sNGgoHw1T72M/A=; b=un+mTFpRvO+UwoZDlT4yNO1tZX EpDj2XElOeymR+dihhi1ZMsWTZGqDVrYrVJhmYui4wSi7MLYs17pTBwGG8PncOTTy2z9WiZu3dUHU MyyTf6ReN2UjHNZ0XTUzyCEFtZelN9mJi/UkIT/64J8tqojlt4dGQKn9Qtv9pE8d1SLXVsn1r/g13 gcbL/P7drLVh0cW73KUO5X2QyBUoRPYgJk+kuJBTGeCl2jb7tJADcdv/BMIU2tDpjpnLhffGv8sjL siUoaghAaFSxzEzTUXk9UqQOrJuwuKMj4Ha36ekw7MG7PGSMkSDIVTgamdwm4pMPhnHgLy94JnGn9 DdaHWgMA==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qFTR1-005E3i-0E; Sat, 01 Jul 2023 05:46:15 +0000 Message-ID: Date: Fri, 30 Jun 2023 22:46:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: Randy Dunlap Subject: Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y To: =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20230516152854.22465-1-rdunlap@infradead.org> <20230516185400.urjy6y3kh4grbagt@pali> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Kumar Gala , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/9/23 20:11, Randy Dunlap wrote: > Hi-- > > On 5/16/23 11:54, Pali Rohár wrote: >> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote: >>> In a randconfig with CONFIG_SERIAL_CPM=m and >>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: >>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! >>> >>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when >>> SERIAL_CPM=y. >>> >>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.") >>> Signed-off-by: Randy Dunlap >>> Cc: Scott Wood >>> Cc: Kumar Gala >>> Cc: "Pali Rohár" >>> Cc: Michael Ellerman >>> Cc: Nicholas Piggin >>> Cc: Christophe Leroy >>> Cc: linuxppc-dev@lists.ozlabs.org >> >> Looks good, >> >> Reviewed-by: Pali Rohár > > I'm still seeing this build error in linux-next even with other (PPC) CPM > patches applied. > Patchwork shows status as Superseded: http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230516152854.22465-1-rdunlap@infradead.org/ but I don't understand why or by what. I'm going to resubmit the patch now. >> >>> --- >>> arch/powerpc/Kconfig.debug | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug >>> --- a/arch/powerpc/Kconfig.debug >>> +++ b/arch/powerpc/Kconfig.debug >>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x >>> >>> config PPC_EARLY_DEBUG_CPM >>> bool "Early serial debugging for Freescale CPM-based serial ports" >>> - depends on SERIAL_CPM >>> + depends on SERIAL_CPM=y >>> help >>> Select this to enable early debugging for Freescale chips >>> using a CPM-based serial port. This assumes that the bootwrapper > -- ~Randy