From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in-10.arcor-online.net (mail-in-10.arcor-online.net [151.189.21.50]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.arcor.de", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id E4107DDFB0 for ; Fri, 4 May 2007 02:21:44 +1000 (EST) In-Reply-To: <4639E389.4040604@ru.mvista.com> References: <20070501051804.GB3881@localhost.localdomain> <20070503103534.63ff67b6@localhost.localdomain> <20070503070358.GA9430@localhost.localdomain> <4639CF44.6020608@ru.mvista.com> <20070503122213.GD26659@localhost.localdomain> <4639E389.4040604@ru.mvista.com> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: From: Segher Boessenkool Subject: Re: powerpc_flash_init(), wtf!? Date: Thu, 3 May 2007 18:21:35 +0200 To: Sergei Shtylyov Cc: linuxppc-dev@ozlabs.org, David Gibson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > BTW, is it legal/appropriate to specify device (not bus) types for > of_platform_bus_probe()? In almost all cases you should probe on "name"/"compatible", and not use "device_type" at all. Segher