From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <20080310235429.GC11559@localhost.localdomain> References: <1204800155-11613-1-git-send-email-leoli@freescale.com> <20080307002730.GB24142@localhost.localdomain> <9f7d0248e911f6fa1a2d4292c96ef72e@kernel.crashing.org> <20080310235429.GC11559@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: From: Segher Boessenkool Subject: Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees. Date: Tue, 11 Mar 2008 19:43:27 +0100 To: David Gibson Cc: linuxppc-dev@ozlabs.org, Li Yang , paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> This isn't a problem with this device tree, but it's probably time we >>> started establishing some conventional generic names for nand flash >>> and board-control devices. >>> >>> So, to start the ball rolling, I've seen several names for nand flash >>> nodes, I'd suggest we standardise on "nand-flash". >> >> What's wrong with the already well-established generic name "flash"? > > I was concerned that using "flash" for both NOR flash (which it > already is) and NAND flash might be unwise. I am quite open to being > convinced otherwise, though. You already said you're convinced, but I'll add another argument anyway... For NAND flash, there will usually be a parent node named "nand-controller" or similar, while NOR flash will typically be direct-mapped. There is always this tension between making the names as generic as possible, and not losing too much information. In my experience, you can always make leaf nodes have very very generic names, it's only the bus nodes where this can be harder. And then there are exceptions like "board-control" where there just _is_ no really good name ;-) Segher