linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <dwg@au1.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Document and implement an improved flash device binding
Date: Thu, 6 Sep 2007 15:28:35 +0200	[thread overview]
Message-ID: <a8b4282d0c58f1090c64591d387dae97@kernel.crashing.org> (raw)
In-Reply-To: <20070905025907.GG17189@localhost.localdomain>

>>> +     - bank-width : Width (in bytes) of the flash bank.  Equal to 
>>> the
>>> +       device width times the number of interleaved chips.
>>> +     - device-width : (optional) Width of a single flash chip.  If
>>> +       omitted, assumed to be equal to 'bank-width'.
>>
>> Let's have bank-width optional instead, it's more natural
>> that way for the common case of just one chip.  Or, you can
>> say that either is optional.
>
> No, I'm disinclined to do that since bank-width is the primary bit of
> information that the driver needs.

Bzzzzt.  That's not what the device tree is about; it should
describe the hardware, it shouldn't be just a config file for
the current Linux drivers.

Besides, like I said, for the common case where your flash
chips aren't interleaved, it makes way more sense to talk
about device-width than it does to call it bank-width.

>>> +					OpenBIOS@0 {
>>
>> This show immediately why node name = partition name won't
>> work out.  You're not supposed to start a node name with a
>> capital like this.
>
> According to which?

It's just convention, really.

OTOH, spaces and commas and colons and a whole bunch of special
chars are completely disallowed here, so you need...

> Nonetheless, I've added a label property,

...something like that :-)


Segher

  reply	other threads:[~2007-09-06 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29  6:13 Document and implement an improved flash device binding David Gibson
2007-08-29  8:43 ` Domen Puncer
2007-08-30  1:18   ` David Gibson
2007-09-03 10:23 ` Segher Boessenkool
2007-09-05  2:59   ` David Gibson
2007-09-06 13:28     ` Segher Boessenkool [this message]
2007-09-07  1:04       ` David Gibson
2007-09-07 13:58         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8b4282d0c58f1090c64591d387dae97@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dwg@au1.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).