From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.mleia.com (mleia.com [178.79.152.223]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3s80Sv0WWqzDqCb for ; Wed, 10 Aug 2016 02:42:54 +1000 (AEST) Subject: Re: [PATCH] i2c: don't print error when adding adapter fails To: Wolfram Sang , linux-kernel@vger.kernel.org References: <1470742581-12971-1-git-send-email-wsa-dev@sang-engineering.com> <1470742581-12971-2-git-send-email-wsa-dev@sang-engineering.com> Cc: linux-i2c@vger.kernel.org, Jean Delvare , Wolfram Sang , Ludovic Desroches , Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Sonic Zhang , Brian Norris , Gregory Fong , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Jochen Friedrich , Sekhar Nori , Kevin Hilman , Guenter Roeck , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Kukjin Kim , Krzysztof Kozlowski , Seth Heasley , Neil Horman , Joachim Eastwood , Carlo Caione , Alessandro Rubini , Linus Walleij , Peter Korsgaard , Tony Lindgren , Sylvain Lemieux , Guan Xuetao , Heiko Stuebner , Barry Song , Patrice Chotard , Laxman Dewangan , Stephen Warren , Thierry Reding , Alexandre Courbot , Masahiro Yamada , Tony Prisk , linux-arm-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@stlinux.com, linux-tegra@vger.kernel.org From: Vladimir Zapolskiy Message-ID: Date: Tue, 9 Aug 2016 19:36:55 +0300 MIME-Version: 1.0 In-Reply-To: <1470742581-12971-2-git-send-email-wsa-dev@sang-engineering.com> Content-Type: text/plain; charset=windows-1252 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 09.08.2016 14:36, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- For > drivers/i2c/busses/i2c-pnx.c | 4 +--- [snip] > diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c > index 7ea67aa46fb730..fd5f9d2bf6d94e 100644 > --- a/drivers/i2c/busses/i2c-pnx.c > +++ b/drivers/i2c/busses/i2c-pnx.c > @@ -714,10 +714,8 @@ static int i2c_pnx_probe(struct platform_device *pdev) > > /* Register this adapter with the I2C subsystem */ > ret = i2c_add_numbered_adapter(&alg_data->adapter); > - if (ret < 0) { > - dev_err(&pdev->dev, "I2C: Failed to add bus\n"); > + if (ret < 0) > goto out_clock; > - } > > dev_dbg(&pdev->dev, "%s: Master at %#8x, irq %d.\n", > alg_data->adapter.name, res->start, alg_data->irq); Acked-by: Vladimir Zapolskiy -- With best wishes, Vladimir