linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Shuai Xue <xueshuai@linux.alibaba.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, bhelgaas@google.com,
	kbusch@kernel.org
Cc: mahesh@linux.ibm.com, oohall@gmail.com,
	Jonathan.Cameron@huawei.com, terry.bowman@amd.com,
	tianruidong@linux.alibaba.com, lukas@wunner.de
Subject: Re: [PATCH v6 4/5] PCI/ERR: Use pcie_aer_is_native() to check for native AER control
Date: Mon, 20 Oct 2025 11:43:11 -0700	[thread overview]
Message-ID: <a92c343a-919d-4940-b142-4919d90eb9f3@linux.intel.com> (raw)
In-Reply-To: <20251015024159.56414-5-xueshuai@linux.alibaba.com>


On 10/14/25 19:41, Shuai Xue wrote:
> Replace the manual checks for native AER control with the
> pcie_aer_is_native() helper, which provides a more robust way
> to determine if we have native control of AER.
>
> No functional changes intended.
>
> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

>   drivers/pci/pcie/err.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c
> index 4e65eac809d1..097990094b71 100644
> --- a/drivers/pci/pcie/err.c
> +++ b/drivers/pci/pcie/err.c
> @@ -214,7 +214,6 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
>   	int type = pci_pcie_type(dev);
>   	struct pci_dev *bridge;
>   	pci_ers_result_t status = PCI_ERS_RESULT_CAN_RECOVER;
> -	struct pci_host_bridge *host = pci_find_host_bridge(dev->bus);
>   	struct aer_err_info info;
>   
>   	/*
> @@ -289,7 +288,7 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
>   	 * it is responsible for clearing this status.  In that case, the
>   	 * signaling device may not even be visible to the OS.
>   	 */
> -	if (host->native_aer || pcie_ports_native) {
> +	if (pcie_aer_is_native(dev)) {
>   		pcie_clear_device_status(dev);
>   		pci_aer_clear_nonfatal_status(dev);
>   	}


  parent reply	other threads:[~2025-10-20 18:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  2:41 [PATCH v6 0/5] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd Shuai Xue
2025-10-15  2:41 ` [PATCH v6 1/5] PCI/DPC: Clarify naming for error port in DPC Handling Shuai Xue
2025-10-15  2:41 ` [PATCH v6 2/5] PCI/DPC: Run recovery on device that detected the error Shuai Xue
2025-10-15  2:41 ` [PATCH v6 3/5] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd Shuai Xue
2025-10-20 10:10   ` Lukas Wunner
2025-10-20 12:58     ` Shuai Xue
2025-10-20 13:54       ` Lukas Wunner
2025-10-20 14:17         ` Shuai Xue
2025-10-20 14:24           ` Lukas Wunner
2025-10-20 15:20             ` Shuai Xue
2025-10-23 10:48               ` Lukas Wunner
2025-10-24  6:43                 ` Shuai Xue
2025-10-20 18:38   ` Kuppuswamy Sathyanarayanan
2025-10-21  1:51     ` Shuai Xue
2025-10-15  2:41 ` [PATCH v6 4/5] PCI/ERR: Use pcie_aer_is_native() to check for native AER control Shuai Xue
2025-10-20 10:17   ` Lukas Wunner
2025-10-20 13:09     ` Shuai Xue
2025-10-20 13:58       ` Lukas Wunner
2025-10-20 14:45         ` Shuai Xue
2025-10-23 10:29           ` Lukas Wunner
2025-10-24  3:09             ` Shuai Xue
2025-10-24  3:14               ` Lukas Wunner
2025-10-24  3:38                 ` Shuai Xue
2025-10-24  4:03                   ` Lukas Wunner
2025-10-24  5:37                     ` Shuai Xue
2025-10-20 18:43   ` Kuppuswamy Sathyanarayanan [this message]
2025-10-15  2:41 ` [PATCH v6 5/5] PCI/AER: Clear both AER fatal and non-fatal status Shuai Xue
2025-10-20 18:44   ` Kuppuswamy Sathyanarayanan
2025-10-21  1:33     ` Shuai Xue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a92c343a-919d-4940-b142-4919d90eb9f3@linux.intel.com \
    --to=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukas@wunner.de \
    --cc=mahesh@linux.ibm.com \
    --cc=oohall@gmail.com \
    --cc=terry.bowman@amd.com \
    --cc=tianruidong@linux.alibaba.com \
    --cc=xueshuai@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).