From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8608CC433F5 for ; Tue, 5 Oct 2021 05:50:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D024E6120D for ; Tue, 5 Oct 2021 05:50:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D024E6120D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HNmsM2ZfCz2ywY for ; Tue, 5 Oct 2021 16:50:47 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.235.10; helo=pegase2.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HNmrv2h4Rz2yMy for ; Tue, 5 Oct 2021 16:50:22 +1100 (AEDT) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4HNmrr00g5z9sVN; Tue, 5 Oct 2021 07:50:20 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MkznaSMcms_y; Tue, 5 Oct 2021 07:50:19 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4HNmrq66T1z9sV4; Tue, 5 Oct 2021 07:50:19 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B505F8B770; Tue, 5 Oct 2021 07:50:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id XM5qyo8sPpt2; Tue, 5 Oct 2021 07:50:19 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (unknown [192.168.204.122]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 0D3268B765; Tue, 5 Oct 2021 07:50:18 +0200 (CEST) Subject: Re: [PATCH 3/9] powerpc/bpf: Remove unused SEEN_STACK To: "Naveen N. Rao" , Alexei Starovoitov , Daniel Borkmann , Johan Almbladh , Michael Ellerman , Nicholas Piggin References: <92fcd53a43dede52fbba52dc50c76042a6ce284c.1633104510.git.naveen.n.rao@linux.vnet.ibm.com> <1633369544.ekqufta9bg.naveen@linux.ibm.com> From: Christophe Leroy Message-ID: Date: Tue, 5 Oct 2021 07:50:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1633369544.ekqufta9bg.naveen@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr-FR Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 04/10/2021 à 20:11, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> >> >> Le 01/10/2021 à 23:14, Naveen N. Rao a écrit : >>> From: Ravi Bangoria >>> >>> SEEN_STACK is unused on PowerPC. Remove it. Also, have >>> SEEN_TAILCALL use 0x40000000. >> >> Why change SEEN_TAILCALL ? Would it be a problem to leave it as is ? >> >>> >>> Signed-off-by: Ravi Bangoria >>> Reviewed-by: Christophe Leroy > > I prefer the bit usage to be contiguous. Changing SEEN_TAILCALL isn't a > problem either. > Well you are adding SEEN_BIG_PROG in following patch so it would still be contiguous at the end. I don't really mind but I thought it would be less churn to just leave SEEN_TAILCALL as is and re-use 0x40000000 for SEEN_BIG_PROG. Anyway Reviewed-by: Christophe Leroy