From: Sumit Garg <sumit.garg@kernel.org>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Jarkko Sakkinen <jarkko@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Peter Huewe <peterhuewe@gmx.de>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Naveen N Rao <naveen@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v3 3/4] tpm/tpm_ftpm_tee: support TPM_CHIP_FLAG_SYNC
Date: Mon, 28 Apr 2025 13:19:24 +0530 [thread overview]
Message-ID: <aA8zBP6h8oG5m4w9@sumit-X1> (raw)
In-Reply-To: <CAGxU2F5SJ9nQfAV-D1WKjsUow_01xjGBRXP4d+q4T=5Bw=yaOg@mail.gmail.com>
On Mon, Apr 14, 2025 at 04:59:47PM +0200, Stefano Garzarella wrote:
> On Mon, 14 Apr 2025 at 16:57, Stefano Garzarella <sgarzare@redhat.com> wrote:
> >
> > From: Stefano Garzarella <sgarzare@redhat.com>
> >
> > This driver does not support interrupts, and receiving the response is
> > synchronous with sending the command.
> >
> > So we can set TPM_CHIP_FLAG_SYNC to support synchronous send() and
> > return responses in the same buffer used for commands. This way we
> > don't need the 4KB internal buffer used to cache the response before
> > .send() and .recv(). Also we don't need to implement recv() op.
> >
> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> > ---
> > v2:
> > - set TPM_CHIP_FLAG_SYNC and support it in the new send()
> > - removed Jens' T-b
>
> @Jens @Sumit can you test/review this patch again since from v1 we
> changed the core a bit adding TPM_CHIP_FLAG_SYNC instead of
> send_recv() op?
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
-Sumit
next prev parent reply other threads:[~2025-04-28 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 14:56 [PATCH v3 0/4] tpm: add support for sync send() and use it in ftpm and svsm drivers Stefano Garzarella
2025-04-14 14:56 ` [PATCH v3 1/4] tpm: add buf_size parameter in the .send callback Stefano Garzarella
2025-04-30 15:39 ` Jarkko Sakkinen
2025-05-06 12:56 ` Stefano Garzarella
2025-05-08 20:00 ` Jarkko Sakkinen
2025-04-14 14:56 ` [PATCH v3 2/4] tpm: support devices with synchronous send() Stefano Garzarella
2025-04-30 15:41 ` Jarkko Sakkinen
2025-04-14 14:56 ` [PATCH v3 3/4] tpm/tpm_ftpm_tee: support TPM_CHIP_FLAG_SYNC Stefano Garzarella
2025-04-14 14:59 ` Stefano Garzarella
2025-04-28 7:49 ` Sumit Garg [this message]
2025-04-30 15:47 ` Jarkko Sakkinen
2025-05-06 13:03 ` Stefano Garzarella
2025-04-14 14:56 ` [PATCH v3 4/4] tpm/tpm_svsm: " Stefano Garzarella
2025-04-30 15:49 ` Jarkko Sakkinen
2025-05-06 13:06 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA8zBP6h8oG5m4w9@sumit-X1 \
--to=sumit.garg@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alexandre.belloni@bootlin.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@tuxon.dev \
--cc=jarkko@kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=npiggin@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).