From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52411C3ABBE for ; Thu, 8 May 2025 20:00:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZtjgF67ldz2xs7; Fri, 9 May 2025 06:00:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1746734457; cv=none; b=mqdU8n2yrbIZPrZN5Uaua8pr9P+gdeK9wRJh+a+5cFIG4yr3L+u5BhdejHY8BcbQr72FsdSahBoTVEab+YIcClEuMfGs2xiHNxAuc/Mal1RD1YURjaUPOIrlvl2GnPr1m+qNkIjnElr2y4rfJD+898pBJ8asiTe35V+npBpfizhNBsU6opSPW9UGmdVba+/6WTUug8o+wWzWo2yIIThK8hN39HOGQlm2ks3ZjNuLCSk+inzJMsG0uuZI2aGs8WSZsdF9DKTjnNqHNDR9TKtIJXIKDoie+MTtsn6mb+vuNpomBu/8cRgg3SbNr0H7GK0z7wEF1BGqqOQHhkxXxWQQnA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1746734457; c=relaxed/relaxed; bh=WcTOiqY3Q13roGwqiggNCr+ilIh5tTP+DT9I/IZ7qsE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S4ZStIh4WgcTnQHDWFyMHJXJuov8xSenIvI10V5ANEoDYmBw9wjWPqCPlXYCauUwjQYKcTeHKzt2uqADehrJIjfAHHqAfERxJYhRkDJChk6mL0M4uhMuS+i/GL9b97I3KUEwi00PruyUN1BONLctQabr4zKUYBCbIN0P6DVIDaPzmXoyrM7XBWaYO3IUFYFv62XyQAjgNwDoia6H/C1VbqG5WjzsHY8lsSgsOsuxNo54laHYZWl9m8selnWjn+mV8VWSJ8qAsetk4fiFnm3W2rTtC/DidZPBru2j220gT7KjCcyM8RjiS789UXJP977NgFu/tkTamqhpRRb+ddbYZQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=l5aKvbvo; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=l5aKvbvo; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZtjgF1nmcz2xqC for ; Fri, 9 May 2025 06:00:57 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id AE5E344ED2; Thu, 8 May 2025 20:00:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D93FDC4CEE7; Thu, 8 May 2025 20:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746734454; bh=RkjjpKYG+r35+gc9d0tTnqu/pElbyqXWwGFn4pZKP4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l5aKvbvoZXXzxoR08YFj5FH5BYBKSoSB5/P6wBMQaV75fDXFA7Zlnr2BGbwqroxU4 se3IIq+1q6ZCT6StAGKBgYyklxpO9vZqxh+7+j96coWFcBuJiRpQ9TzxENPmgeY1zi L9dEOl/IE3bWTKodiCXQa1hmweDbecZLdE24AOlPAUmynQ+YnJzDM5bAvErNcQyElo T0SYuZRCPAbKY1HY+B5LZmStBmb78AFhB5pGDL9NFTzQ3IJFJLK50MAhTJLyh8NVEs 1GbawfQ4AVJazKSphVFxJEhd4yNWLMmnDj44J7nR+KePu3+Ku/P+2NsX1MRg1YwLy9 MQMYF0SOMcLEQ== Date: Thu, 8 May 2025 23:00:49 +0300 From: Jarkko Sakkinen To: Stefano Garzarella Cc: Christophe Leroy , Peter Huewe , Alexandre Belloni , Jens Wiklander , Claudiu Beznea , Naveen N Rao , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, Nicolas Ferre , Michael Ellerman , Madhavan Srinivasan , James Bottomley , linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sumit Garg , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v3 1/4] tpm: add buf_size parameter in the .send callback Message-ID: References: <20250414145653.239081-1-sgarzare@redhat.com> <20250414145653.239081-2-sgarzare@redhat.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 06, 2025 at 02:56:54PM +0200, Stefano Garzarella wrote: > On Wed, Apr 30, 2025 at 06:39:58PM +0300, Jarkko Sakkinen wrote: > > On Mon, Apr 14, 2025 at 04:56:50PM +0200, Stefano Garzarella wrote: > > > From: Stefano Garzarella > > > > > > In preparation for the next commit, add a new `buf_size` parameter to > > > the `.send` callback in `tpm_class_ops` which contains the entire buffer > > > size. In this patch it is pretty much ignored by all drivers, but it will > > > be used in the next patch. > > > > So instead "in preparation for the next commit" just plain say why it > > will be needed. "next commit" is a fuzzy reference :-) > > > > Same goes for "next patch". Neither can be used to query any possible > > information. That sort of makes the whole paragraph useless, once it > > is in the commit log. > > Got it! What about somethig like this: > > Add a new `buf_size` parameter to the `.send` callback in > `tpm_class_ops`. This parameter will allow drivers to differentiate > between the actual command length to send and the total buffer > size. Currently `buf_now` is not used, but it will be used to > support devices with synchronous `.send` callback to send the > command and receive the response on the same buffer. definitely to right direction > > Thanks, > Stefano BR, Jarkko