From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode
Date: Mon, 19 May 2025 13:25:13 +0200 [thread overview]
Message-ID: <aCsVGUAQ61zAgXMl@shikoro> (raw)
In-Reply-To: <aCsTjM49Ll2fcv4j@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
> > - info.of_node = of_node_get(node);
> > + info.fwnode = of_fwnode_handle(of_node_get(node));
>
> What puzzles me here is that of_node_get(). We already do the same in the I²C
> core, does it really need the second bump of the reference counting?
I'd think so. i2c_board_info has its own source file outside of the I2C
core because it is used before the I2C core is even initialized. That is
basically the reason for its existence.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-05-19 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 11:13 [PATCH 0/3] i2c: remove 'of_node' from i2c_board_info Wolfram Sang
2025-05-19 11:13 ` [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode Wolfram Sang
2025-05-19 11:18 ` Andy Shevchenko
2025-05-19 11:25 ` Wolfram Sang [this message]
2025-05-19 22:03 ` Andi Shyti
2025-05-20 9:15 ` Wolfram Sang
2025-05-20 9:39 ` Andi Shyti
2025-05-19 11:19 ` [PATCH 0/3] i2c: remove 'of_node' from i2c_board_info Andy Shevchenko
2025-05-20 20:50 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCsVGUAQ61zAgXMl@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).