From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 721E4C5AE59 for ; Wed, 28 May 2025 06:44:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4b6g3S5nLWz2xHT; Wed, 28 May 2025 16:44:52 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a01:4f8:150:2161:1:b009:f23e:0" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1748414692; cv=none; b=nZq0yRaxRc0Gj2ApYOQXHZzrDeEPyE3j1kdx1eCcyCpF6sT5r7IsaQjWSq6dH34fgm9Kh+MUVRy5iLSdarRx8i3BTXDjA7/G6pT1E6soYqZNZAnhv7qFd/sP8gWIbzjk/n5iOUXsE4TmQethvEhBtBu6Au3OVZPtF67AkvMsu4R2uXy1+rqUz2vZJL0vGJReNp5Y5J7NlNacr5KHrf1hBDgi0kECu4Qy2hNo1v+A8hL2WIzmdDOhLYVLOq5dlbd2dnqMtttRDyb9hsUmIBvfcPi4NndyyCQRXBiff6qzfNmy5F76AYr9/pfhRu2bD0Dd07rWuNpqRnAd5hVZpUY/zg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1748414692; c=relaxed/relaxed; bh=+LpbCzVDV/6N/5wpLgx4cNGbaE/jYucytTebCP0K3tk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m6D8VLZld7DzbcvB956xRtmmh5ASh8Lrw+skxO2VmFafXo3f7aYVXMdXIgAcKrHsz0FsDDrSQEDOnJtzFGBIyspzgJyN8sTCEeV5YxAX2O2GrAkqLFwCKyShnE6sk/IgzBDK2MOKsgWELbuCnUzZ8MJSyV2Pdu7g2kOVjDwm4Khg/3SmBwP7massq0ZpXYJXEeq94fODKpw/EaF0HGlEvVrFd/II9tlEefppizJ5G4ZDoJpQczwCvjVSO1JuskeZVf03kAegrkmanJ9Cbwbt5xwYZMK27eHEUX7wSz/dTSgETapGqcj+fGuGiEKic3dxD6Go341sWjXP17WLIQ9WVw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=pass (client-ip=2a01:4f8:150:2161:1:b009:f23e:0; helo=bmailout3.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver=lists.ozlabs.org) smtp.helo=bmailout3.hostsharing.net Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=bmailout3.hostsharing.net (client-ip=2a01:4f8:150:2161:1:b009:f23e:0; helo=bmailout3.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver=lists.ozlabs.org) X-Greylist: delayed 350 seconds by postgrey-1.37 at boromir; Wed, 28 May 2025 16:44:50 AEST Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [IPv6:2a01:4f8:150:2161:1:b009:f23e:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4b6g3Q5Ttxz2xGw for ; Wed, 28 May 2025 16:44:50 +1000 (AEST) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 7F9772C0AD18; Wed, 28 May 2025 08:38:51 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 3F699176016; Wed, 28 May 2025 08:38:51 +0200 (CEST) Date: Wed, 28 May 2025 08:38:51 +0200 From: Lukas Wunner To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Jon Pan-Doh , Karolina Stolarek , Weinan Liu , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Sathyanarayanan Kuppuswamy , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas Subject: Re: [PATCH v8 13/20] PCI/ERR: Add printk level to pcie_print_tlp_log() Message-ID: References: <20250522232339.1525671-1-helgaas@kernel.org> <20250522232339.1525671-14-helgaas@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250522232339.1525671-14-helgaas@kernel.org> On Thu, May 22, 2025 at 06:21:19PM -0500, Bjorn Helgaas wrote: > @@ -130,6 +132,6 @@ void pcie_print_tlp_log(const struct pci_dev *dev, > } > } > > - pci_err(dev, "%sTLP Header%s: %s\n", pfx, > + dev_printk(level, &dev->dev, "%sTLP Header%s: %s\n", pfx, > log->flit ? " (Flit)" : "", buf); > } Nit: pci_printk() ? The definition in include/linux/pci.h was retained by fab874e12593.