From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Support Opensource <support.opensource@diasemi.com>,
Oder Chiou <oder_chiou@realtek.com>,
Srinivas Kandagatla <srini@kernel.org>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables
Date: Thu, 29 May 2025 11:09:59 +0100 [thread overview]
Message-ID: <aDgyd2S/j3MW4JCg@opensource.cirrus.com> (raw)
In-Reply-To: <20250528-asoc-const-unused-v1-1-19a5d07b9d5c@linaro.org>
On Wed, May 28, 2025 at 09:59:55PM +0200, Krzysztof Kozlowski wrote:
> Static arrays/structs for regmap configuration like 'struct
> reg_default', 'struct reg_sequence' and others are not modified so can
> be changed to const for more safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> sound/soc/codecs/cs35l36.c | 2 +-
>
> diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c
> index b49c6905e8727d7c07fd10e668507ca07bf2cff5..b60697ff7a506dccf3dba1b01faa985761bbbc42 100644
> --- a/sound/soc/codecs/cs35l36.c
> +++ b/sound/soc/codecs/cs35l36.c
> -static struct reg_default cs35l36_reg[] = {
> +static const struct reg_default cs35l36_reg[] = {
> {CS35L36_TESTKEY_CTRL, 0x00000000},
> {CS35L36_USERKEY_CTL, 0x00000000},
> {CS35L36_OTP_CTRL1, 0x00002460},
For the cs35l56:
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2025-05-29 10:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 19:59 [PATCH 0/8] ASoC: codecs: More const and unused member cleanups Krzysztof Kozlowski
2025-05-28 19:59 ` [PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables Krzysztof Kozlowski
2025-05-29 9:28 ` Srinivas Kandagatla
2025-05-29 10:09 ` Charles Keepax [this message]
2025-05-28 19:59 ` [PATCH 2/8] ASoC: fsl: Constify reg_default array Krzysztof Kozlowski
2025-05-28 19:59 ` [PATCH 3/8] ASoC: codecs: wcd9335: Drop unused sido_input_src field Krzysztof Kozlowski
2025-05-29 9:27 ` Srinivas Kandagatla
2025-05-28 19:59 ` [PATCH 4/8] ASoC: codecs: wcd934x: Drop unused num_rx_port/num_tx_port fields Krzysztof Kozlowski
2025-05-29 9:29 ` Srinivas Kandagatla
2025-05-28 19:59 ` [PATCH 5/8] ASoC: codecs: wcd937x: Drop unused 'struct wcd937x_priv' fields Krzysztof Kozlowski
2025-05-29 9:30 ` Srinivas Kandagatla
2025-05-28 20:00 ` [PATCH 6/8] ASoC: codecs: wcd938x: Drop unused 'struct wcd938x_priv' fields Krzysztof Kozlowski
2025-05-29 9:30 ` Srinivas Kandagatla
2025-05-28 20:00 ` [PATCH 7/8] ASoC: codecs: wcd938x: Drop unused variant field Krzysztof Kozlowski
2025-05-29 9:31 ` Srinivas Kandagatla
2025-05-28 20:00 ` [PATCH 8/8] ASoC: codecs: wcd939x: Drop unused 'struct wcd939x_priv' fields Krzysztof Kozlowski
2025-05-29 9:31 ` Srinivas Kandagatla
2025-05-29 9:33 ` [PATCH 0/8] ASoC: codecs: More const and unused member cleanups Srinivas Kandagatla
2025-05-29 9:38 ` Krzysztof Kozlowski
2025-06-09 21:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDgyd2S/j3MW4JCg@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=shengjiu.wang@gmail.com \
--cc=srini@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).