From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FC29C87FCA for ; Thu, 7 Aug 2025 11:34:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4byQ7H2zScz2xck; Thu, 7 Aug 2025 21:34:51 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=83.223.95.100 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1754566491; cv=none; b=RmufyeB3pxov1igQBxDB4N/4iwSIjxcCwnu6kx5n+DswhwHKYemuoivJHstv6jHiDcn9t/s89k0ro/nvRXU3P9XuVvYTcrCZipnmHHcgzHeZ+dNhwTwO1vCDAdAX0yi/TEtxMcMChEkYxMWUuLoSD/f7Kvm0K4JhQVfyY6VbpGXT5Pw9dcwB86Q/L0/CWCMsNn07ZZXYc+jHFJb4JvhRSx7EegcpFP43UMC6Qcmsk/y0OYFeigYKF4/21pdAyengCOGYQCc4b3DIu6QIQgkAkca9FQRvOnO3URxBya7b2sXcGKsTUrJD9wPyuLBsgdwAfmAjI4PMkebDekwoKtHQSQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1754566491; c=relaxed/relaxed; bh=G6vZA4wmQaLjgQfEsmiovY05d3mgMfUQwi8NEhL89MM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RxmHXtu8DDH6sjkEhAD/KdDXLqTPB9LolhQbNGu0PV55jyrqJgTx1mdI2McIv3dcRGMCvI5A5JCsgzvNhTa6i8tE2t1c4PBb43qRT9NXxsNN2VwY4IBKmM+TxzKajqcktWqOPyrjtBpQ6BO2wc9/eStDiNraIARz0miCQ4OIw9M2g0inxKn0NPZ8ugiu57IAj8o3g0h5QTubvENgB5zmL5nt52PFQgkWaguYIYZLD3FESi4IAN86Z9yNa4bOecow816WNrtgrqTACXjIbrmFHbRFGYuiawPLIgd4geDaLC9bQ9V+GwR/ZOJppAvW1dNuDpyKhoV+1w44E5tV4p2/eQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=pass (client-ip=83.223.95.100; helo=bmailout1.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver=lists.ozlabs.org) smtp.helo=bmailout1.hostsharing.net Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=bmailout1.hostsharing.net (client-ip=83.223.95.100; helo=bmailout1.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver=lists.ozlabs.org) Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4byQ7G3SPVz2xcG for ; Thu, 7 Aug 2025 21:34:48 +1000 (AEST) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id B89B52C02AF7; Thu, 7 Aug 2025 13:34:43 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id A174D48BAC8; Thu, 7 Aug 2025 13:34:43 +0200 (CEST) Date: Thu, 7 Aug 2025 13:34:43 +0200 From: Lukas Wunner To: Niklas Schnelle Cc: Bjorn Helgaas , Mahesh J Salgaonkar , Linas Vepstas , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Manivannan Sadhasivam , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Oberparleiter , Matthew Rosato , Oliver O'Halloran , Sinan Kaya , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Keith Busch Subject: Re: [PATCH v4 2/3] powerpc/eeh: Use result of error_detected() in uevent Message-ID: References: <20250807-add_err_uevents-v4-0-c624bfd8638d@linux.ibm.com> <20250807-add_err_uevents-v4-2-c624bfd8638d@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250807-add_err_uevents-v4-2-c624bfd8638d@linux.ibm.com> On Thu, Aug 07, 2025 at 12:15:32PM +0200, Niklas Schnelle wrote: > With pci_uevent_ers() handling PCI_ERS_RESULT_NEED_RESET the result of > error_detected() can be used in pci_uevent_ers() even if drivers request > a reset. This aligns EEH's behavior with both AER. I guess the sentence is supposed to end with "and s390"? I would have recounted the history a bit, e.g.: Ever since uevent support was added for AER and EEH with commit 856e1eb9bdd4 ("PCI/AER: Add uevents in AER and EEH error/resume"), it reported PCI_ERS_RESULT_NONE as the result of ->error_detected() to user space. Commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for udev") subsequently amended AER to report the actual return value of ->error_detected(). Make the same change to EEH to align it with AER (and s390 error recovery). > Suggested-by: Lukas Wunner > Link: https://lore.kernel.org/linux-pci/aIp6LiKJor9KLVpv@wunner.de/ > Signed-off-by: Niklas Schnelle Reviewed-by: Lukas Wunner