From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5.4 only] powerpc: boot: Remove unnecessary zero in label in udelay()
Date: Wed, 3 Sep 2025 01:15:38 -0500 [thread overview]
Message-ID: <aLfdCkj4z99QmfMd@gate> (raw)
In-Reply-To: <20250902235234.2046667-1-nathan@kernel.org>
Hi!
On Tue, Sep 02, 2025 at 04:52:34PM -0700, Nathan Chancellor wrote:
> When building powerpc configurations in linux-5.4.y with binutils 2.43
> or newer, there is an assembler error in arch/powerpc/boot/util.S:
>
> arch/powerpc/boot/util.S: Assembler messages:
> arch/powerpc/boot/util.S:44: Error: junk at end of line, first unrecognized character is `0'
> arch/powerpc/boot/util.S:49: Error: syntax error; found `b', expected `,'
> arch/powerpc/boot/util.S:49: Error: junk at end of line: `b'
>
> binutils 2.43 contains stricter parsing of certain labels [1].
>
> Remove the unnecessary leading zero to fix the build.
To fix it by getting rid of this syntax error, you mean? "00" is not a
valid label name: a) it cannot be a symbol name, it starts with a digit;
and b) it isn't a valid local label either. As the manual says
> To define a local label, write a label of the form ‘N:’ (where N
> represents any non-negative integer).
"0" is written "0", not as "00" (or "0-0" or even "0-0-0", hehe).
Segher
next prev parent reply other threads:[~2025-09-03 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 23:52 [PATCH 5.4 only] powerpc: boot: Remove unnecessary zero in label in udelay() Nathan Chancellor
2025-09-03 6:15 ` Segher Boessenkool [this message]
2025-09-03 21:14 ` Nathan Chancellor
2025-09-03 21:19 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLfdCkj4z99QmfMd@gate \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=npiggin@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).