From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD5D3CA100B for ; Wed, 3 Sep 2025 06:16:13 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4cGsn83r4Pz2yFJ; Wed, 3 Sep 2025 16:16:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=63.228.1.57 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1756880172; cv=none; b=V7ZW6fLCZNpx3CUQvwIdfxBq0jJDgHuBN/v4QlSFr8YNqPXVT9wfeK9WJqOEoVfIVDBsdpIUmgyFZfyt8IPPTDxqvGSAhEIwAKM2gvm1E3KtIunBj2VS7E0Y1iuJdf2ieSx583cAEpmLG53tvBPNzAaJDIMyn62WdWXFI0zaRREPr87QpVr3NLCLa0h5wz3g/HhdOZZQgPjcE1uD2Togh4K69U10blPyquY3MhpdA767vZOhZzc3DFn4RMapYU/TjccpsaxUyAJRIo/vPIdH2fPWiDQR2ediQi5kJ6d5ujGe9ZnNY6iFQGffaJvBZ4XNCdSNqClNZoNGO5aHiFBV7Q== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1756880172; c=relaxed/relaxed; bh=pVH77k9WVfNagR7TnzL3kxZFduWcqv+jM0mglh+AsHA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K/R0RCbtoAsykc5xBU9fHDcwsAzuMHaP1nWi4Axg9fKfa+K9+9S69BPD171Pximu/nTcDgt0z0c52CDpgcwtXPy1KnmzjfGD16iaBVMD6EE1wXdBmCeL98Ex96Ey2bzzmSxWg7tFRk38MgOTl01OpkRvRuG83nEyU5jtSVykouUc7fvtc6MbFQJbr3JehgyhFDpmfCSZ0PG041yweERKLsMt8NHx29o+v7LgXdMSw2V2uEvpLe4+Z80VFsAcjunv8fYpJdgWnM0dh2f3HtmVO3le/vConp/A3qa6hagwpWpRV1nEmh4XF6Mbh8Cg8QrbGwsCEV4zaCUeQxfUuMV/iA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org; spf=pass (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.crashing.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=lists.ozlabs.org) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4cGsn40wPsz2xnw for ; Wed, 3 Sep 2025 16:16:07 +1000 (AEST) Received: from gate.crashing.org (localhost [127.0.0.1]) by gate.crashing.org (8.18.1/8.18.1/Debian-2) with ESMTP id 5836FdIZ3679080; Wed, 3 Sep 2025 01:15:39 -0500 Received: (from segher@localhost) by gate.crashing.org (8.18.1/8.18.1/Submit) id 5836FcKJ3679079; Wed, 3 Sep 2025 01:15:38 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 3 Sep 2025 01:15:38 -0500 From: Segher Boessenkool To: Nathan Chancellor Cc: Greg Kroah-Hartman , Sasha Levin , stable@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 5.4 only] powerpc: boot: Remove unnecessary zero in label in udelay() Message-ID: References: <20250902235234.2046667-1-nathan@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250902235234.2046667-1-nathan@kernel.org> Hi! On Tue, Sep 02, 2025 at 04:52:34PM -0700, Nathan Chancellor wrote: > When building powerpc configurations in linux-5.4.y with binutils 2.43 > or newer, there is an assembler error in arch/powerpc/boot/util.S: > > arch/powerpc/boot/util.S: Assembler messages: > arch/powerpc/boot/util.S:44: Error: junk at end of line, first unrecognized character is `0' > arch/powerpc/boot/util.S:49: Error: syntax error; found `b', expected `,' > arch/powerpc/boot/util.S:49: Error: junk at end of line: `b' > > binutils 2.43 contains stricter parsing of certain labels [1]. > > Remove the unnecessary leading zero to fix the build. To fix it by getting rid of this syntax error, you mean? "00" is not a valid label name: a) it cannot be a symbol name, it starts with a digit; and b) it isn't a valid local label either. As the manual says > To define a local label, write a label of the form ‘N:’ (where N > represents any non-negative integer). "0" is written "0", not as "00" (or "0-0" or even "0-0-0", hehe). Segher