linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Fwd: Excluded List for "#size-cells" warning
       [not found] <70d76dcf-c7d4-43c5-c169-07054a37195c@yahoo.com>
@ 2025-10-28 23:55 ` Stan Johnson
  2025-10-29  1:17   ` Rob Herring
  0 siblings, 1 reply; 7+ messages in thread
From: Stan Johnson @ 2025-10-28 23:55 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Rob Herring, Finn Thain

-------- Forwarded Message --------
Subject: Excluded List for "#size-cells" warning
Date: Tue, 28 Oct 2025 10:00:25 -0600
From: Stan Johnson <userm57@yahoo.com>
To: debian-powerpc@lists.debian.org
CC: Finn Thain <fthain@linux-m68k.org>, Christophe Leroy 
<christophe.leroy@csgroup.eu>

Hello,

On a PowerBook G3 Pismo running the latest Debian SID, dmesg reports the 
warning shown below. I've also seen the warning on PowerBook Lombard and 
Wallstreet systems. I haven't checked PowerBook 3400c or Kanga.

According to drivers/of/base.c:

-----
         for (; np; np = np->parent) {
                 if (!of_property_read_u32(np, "#size-cells", &cells))
                         return cells;
                 /*
                  * Default root value and walking parent nodes for 
"#size-cells"
                  * is deprecated. Any platforms which hit this warning 
should
                  * be added to the excluded list.
                  */
                 WARN_ONCE(!EXCLUDED_DEFAULT_CELLS_PLATFORMS,
                           "Missing '#size-cells' in %pOF\n", np);
         }
         return OF_ROOT_NODE_SIZE_CELLS_DEFAULT;
-----

I'm not sure how to request that systems be "added to the excluded 
list." Hopefully someone who sees this message will know how to proceed; 
I can help with any testing.

thanks

-Stan Johnson

-----

[    0.215282] ------------[ cut here ]------------
[    0.215587] Missing '#size-cells' in /pci@f2000000/mac-io@17/media-bay@34
[    0.216349] WARNING: CPU: 0 PID: 1 at drivers/of/base.c:134 
of_bus_n_size_cells+0xc0/0xd4
[    0.216904] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 
6.17.5-pmac #1 NONE  f49e64e4b2bea9e24fad7a6e054c9fb4afe07547
[    0.217582] Hardware name: PowerBook3,1 740/750 0x88300 PowerMac
[    0.217953] NIP:  c048b9d0 LR: c048b9d0 CTR: 00000000
[    0.218268] REGS: e101dae0 TRAP: 0700   Not tainted  (6.17.5-pmac)
[    0.218652] MSR:  00029032 <EE,ME,IR,DR,RI>  CR: 28000422  XER: 00000000
[    0.219124]
                GPR00: c048b9d0 e101dba0 c1060000 0000003d 000000eb 
e101da10 e101da08 00000000
                GPR08: c092d09c 00000000 00000000 e101dba0 48000422 
00000000 c0007a54 00000000
                GPR16: 00000000 00000000 00000000 00000000 00000000 
00000000 0000010a c070c25f
                GPR24: c124f418 00000000 e101dc44 e101dc50 c0630aec 
c0727584 c06d21af dfffcd34
[    0.221406] NIP [c048b9d0] of_bus_n_size_cells+0xc0/0xd4
[    0.221745] LR [c048b9d0] of_bus_n_size_cells+0xc0/0xd4
[    0.222080] Call Trace:
[    0.222241] [e101dba0] [c048b9d0] of_bus_n_size_cells+0xc0/0xd4 
(unreliable)
[    0.222695] [e101dbd0] [c0491844] of_bus_default_count_cells+0x38/0x44
[    0.223116] [e101dbf0] [c049165c] __of_get_address+0xc0/0x178
[    0.223487] [e101dc30] [c0492154] __of_address_to_resource+0x38/0x20c
[    0.223900] [e101dc80] [c03b1334] macio_add_one_device+0x210/0x48c
[    0.224318] [e101dce0] [c03b1718] macio_pci_add_devices+0x168/0x1d8
[    0.224723] [e101dd20] [c03b0c50] macio_pci_probe+0xc4/0xf0
[    0.225088] [e101dd40] [c02fab2c] pci_device_probe+0x88/0xf8
[    0.225457] [e101dd60] [c03973d8] really_probe+0x140/0x298
[    0.225826] [e101dd80] [c0397758] driver_probe_device+0x38/0xa8
[    0.226211] [e101ddb0] [c0397994] __driver_attach+0xfc/0x10c
[    0.226580] [e101ddd0] [c0395544] bus_for_each_dev+0x88/0xc4
[    0.226948] [e101de10] [c0396414] bus_add_driver+0xb4/0x1d0
[    0.227311] [e101de40] [c03981e4] driver_register+0xd4/0x110
[    0.227682] [e101de60] [c0803298] do_one_initcall+0x74/0x1f8
[    0.228064] [e101ded0] [c08036f0] kernel_init_freeable+0x258/0x264
[    0.228465] [e101df10] [c0007a78] kernel_init+0x24/0x12c
[    0.228820] [e101df30] [c00132fc] ret_from_kernel_user_thread+0x10/0x18
[    0.229260] ---- interrupt: 0 at 0x0
[    0.229493] Code: 40a20034 3d20c095 3929eb54 89490001 2c0a0000 
40a20020 3c60c072 39400001 7fe4fb78 386375c1 99490001 4bba10a5 
<0fe00000> 83ff0034 4bffff70 39610030
[    0.230502] ---[ end trace 0000000000000000 ]---


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Excluded List for "#size-cells" warning
  2025-10-28 23:55 ` Fwd: Excluded List for "#size-cells" warning Stan Johnson
@ 2025-10-29  1:17   ` Rob Herring
  2025-10-29  7:29     ` Segher Boessenkool
  0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2025-10-29  1:17 UTC (permalink / raw)
  To: Stan Johnson; +Cc: linuxppc-dev, Finn Thain

On Tue, Oct 28, 2025 at 7:05 PM Stan Johnson <userm57@yahoo.com> wrote:
>
> -------- Forwarded Message --------
> Subject: Excluded List for "#size-cells" warning
> Date: Tue, 28 Oct 2025 10:00:25 -0600
> From: Stan Johnson <userm57@yahoo.com>
> To: debian-powerpc@lists.debian.org
> CC: Finn Thain <fthain@linux-m68k.org>, Christophe Leroy
> <christophe.leroy@csgroup.eu>
>
> Hello,
>
> On a PowerBook G3 Pismo running the latest Debian SID, dmesg reports the
> warning shown below. I've also seen the warning on PowerBook Lombard and
> Wallstreet systems. I haven't checked PowerBook 3400c or Kanga.

Can you send me a dump of the device tree on these systems:

dtc -O dts /proc/device-tree

We've been fixing up these cases such as in commit 7e67ef889c9a
("powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7")

Rob


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Excluded List for "#size-cells" warning
  2025-10-29  1:17   ` Rob Herring
@ 2025-10-29  7:29     ` Segher Boessenkool
  2025-10-29 17:00       ` Stan Johnson
  0 siblings, 1 reply; 7+ messages in thread
From: Segher Boessenkool @ 2025-10-29  7:29 UTC (permalink / raw)
  To: Rob Herring; +Cc: Stan Johnson, linuxppc-dev, Finn Thain

On Tue, Oct 28, 2025 at 08:17:27PM -0500, Rob Herring wrote:
> On Tue, Oct 28, 2025 at 7:05 PM Stan Johnson <userm57@yahoo.com> wrote:
> >
> > -------- Forwarded Message --------
> > Subject: Excluded List for "#size-cells" warning
> > Date: Tue, 28 Oct 2025 10:00:25 -0600
> > From: Stan Johnson <userm57@yahoo.com>
> > To: debian-powerpc@lists.debian.org
> > CC: Finn Thain <fthain@linux-m68k.org>, Christophe Leroy
> > <christophe.leroy@csgroup.eu>
> >
> > Hello,
> >
> > On a PowerBook G3 Pismo running the latest Debian SID, dmesg reports the
> > warning shown below. I've also seen the warning on PowerBook Lombard and
> > Wallstreet systems. I haven't checked PowerBook 3400c or Kanga.
> 
> Can you send me a dump of the device tree on these systems:
> 
> dtc -O dts /proc/device-tree
> 
> We've been fixing up these cases such as in commit 7e67ef889c9a
> ("powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7")

And of course it is perfectly fine for an actual Open Firmware to *not*
repeat the defaults.  As the documentation (the main IEEE 1275 thing)
says: "A missing “#size-cells” property signifies the default value of
one."  There are many other places in OF geared towards this default
btw, take for example the "reg" word, that silently assumes your node's
#size-cells is 1, and does completely the wrong thing if not.

Flattened device trees are a fine thing, but the gratuitous ways it
differs from OF, are not.


Segher


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Excluded List for "#size-cells" warning
  2025-10-29  7:29     ` Segher Boessenkool
@ 2025-10-29 17:00       ` Stan Johnson
  2025-10-30 22:14         ` Stan Johnson
  0 siblings, 1 reply; 7+ messages in thread
From: Stan Johnson @ 2025-10-29 17:00 UTC (permalink / raw)
  To: Segher Boessenkool, Rob Herring; +Cc: linuxppc-dev, Finn Thain

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

On 10/29/25 1:29 AM, Segher Boessenkool wrote:
> On Tue, Oct 28, 2025 at 08:17:27PM -0500, Rob Herring wrote:
>> On Tue, Oct 28, 2025 at 7:05 PM Stan Johnson <userm57@yahoo.com> wrote:
>>>
>>> -------- Forwarded Message --------
>>> Subject: Excluded List for "#size-cells" warning
>>> Date: Tue, 28 Oct 2025 10:00:25 -0600
>>> From: Stan Johnson <userm57@yahoo.com>
>>> To: debian-powerpc@lists.debian.org
>>> CC: Finn Thain <fthain@linux-m68k.org>, Christophe Leroy
>>> <christophe.leroy@csgroup.eu>
>>>
>>> Hello,
>>>
>>> On a PowerBook G3 Pismo running the latest Debian SID, dmesg reports the
>>> warning shown below. I've also seen the warning on PowerBook Lombard and
>>> Wallstreet systems. I haven't checked PowerBook 3400c or Kanga.
>>
>> Can you send me a dump of the device tree on these systems:
>>
>> dtc -O dts /proc/device-tree

Please see the attached compressed files containing dtc output for a 
Wallstreet (dtc_wallstreet.txt) and a Pismo (dtc_pismo.txt).

>>
>> We've been fixing up these cases such as in commit 7e67ef889c9a
>> ("powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7")
> 
> And of course it is perfectly fine for an actual Open Firmware to *not*
> repeat the defaults.  As the documentation (the main IEEE 1275 thing)
> says: "A missing “#size-cells” property signifies the default value of
> one."  There are many other places in OF geared towards this default
> btw, take for example the "reg" word, that silently assumes your node's
> #size-cells is 1, and does completely the wrong thing if not.
> 
> Flattened device trees are a fine thing, but the gratuitous ways it
> differs from OF, are not.
> 
> 
> Segher

[-- Attachment #2: dtc_wallstreet.txt.xz --]
[-- Type: application/x-xz, Size: 4728 bytes --]

[-- Attachment #3: dtc_pismo.txt.xz --]
[-- Type: application/x-xz, Size: 52644 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Excluded List for "#size-cells" warning
  2025-10-29 17:00       ` Stan Johnson
@ 2025-10-30 22:14         ` Stan Johnson
  2025-12-08 16:25           ` Stanley J. Johnson
  0 siblings, 1 reply; 7+ messages in thread
From: Stan Johnson @ 2025-10-30 22:14 UTC (permalink / raw)
  To: Segher Boessenkool, Rob Herring; +Cc: linuxppc-dev, Finn Thain

[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]

Attached are the dtc output files for a PB Lombard and a PB 3400c. If 
you need any other information, please let me know.

Thanks for looking into this.

-Stan Johnson

-----

On 10/29/25 11:00 AM, Stan Johnson wrote:
> On 10/29/25 1:29 AM, Segher Boessenkool wrote:
>> On Tue, Oct 28, 2025 at 08:17:27PM -0500, Rob Herring wrote:
>>> On Tue, Oct 28, 2025 at 7:05 PM Stan Johnson <userm57@yahoo.com> wrote:
>>>>
>>>> -------- Forwarded Message --------
>>>> Subject: Excluded List for "#size-cells" warning
>>>> Date: Tue, 28 Oct 2025 10:00:25 -0600
>>>> From: Stan Johnson <userm57@yahoo.com>
>>>> To: debian-powerpc@lists.debian.org
>>>> CC: Finn Thain <fthain@linux-m68k.org>, Christophe Leroy
>>>> <christophe.leroy@csgroup.eu>
>>>>
>>>> Hello,
>>>>
>>>> On a PowerBook G3 Pismo running the latest Debian SID, dmesg reports 
>>>> the
>>>> warning shown below. I've also seen the warning on PowerBook Lombard 
>>>> and
>>>> Wallstreet systems. I haven't checked PowerBook 3400c or Kanga.
>>>
>>> Can you send me a dump of the device tree on these systems:
>>>
>>> dtc -O dts /proc/device-tree
> 
> Please see the attached compressed files containing dtc output for a 
> Wallstreet (dtc_wallstreet.txt) and a Pismo (dtc_pismo.txt).
> 
>>>
>>> We've been fixing up these cases such as in commit 7e67ef889c9a
>>> ("powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7")
>>
>> And of course it is perfectly fine for an actual Open Firmware to *not*
>> repeat the defaults.  As the documentation (the main IEEE 1275 thing)
>> says: "A missing “#size-cells” property signifies the default value of
>> one."  There are many other places in OF geared towards this default
>> btw, take for example the "reg" word, that silently assumes your node's
>> #size-cells is 1, and does completely the wrong thing if not.
>>
>> Flattened device trees are a fine thing, but the gratuitous ways it
>> differs from OF, are not.
>>
>>
>> Segher

[-- Attachment #2: dtc_lombard.txt.xz --]
[-- Type: application/x-xz, Size: 57736 bytes --]

[-- Attachment #3: dtc_3400c.txt.xz --]
[-- Type: application/x-xz, Size: 4128 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Excluded List for "#size-cells" warning
  2025-10-30 22:14         ` Stan Johnson
@ 2025-12-08 16:25           ` Stanley J. Johnson
  2025-12-08 16:29             ` Rob Herring
  0 siblings, 1 reply; 7+ messages in thread
From: Stanley J. Johnson @ 2025-12-08 16:25 UTC (permalink / raw)
  To: Segher Boessenkool, Rob Herring; +Cc: linuxppc-dev, Finn Thain

Hello,

Please let me know if you have any information regarding this issue.

thanks

-Stan Johnson

On 10/30/25 4:14 PM, Stan Johnson wrote:
> Attached are the dtc output files for a PB Lombard and a PB 3400c. If 
> you need any other information, please let me know.
> 
> Thanks for looking into this.
> 
> -Stan Johnson
> 
> -----
> 
> On 10/29/25 11:00 AM, Stan Johnson wrote:
>> On 10/29/25 1:29 AM, Segher Boessenkool wrote:
>>> On Tue, Oct 28, 2025 at 08:17:27PM -0500, Rob Herring wrote:
>>>> On Tue, Oct 28, 2025 at 7:05 PM Stan Johnson <userm57@yahoo.com> wrote:
>>>>>
>>>>> -------- Forwarded Message --------
>>>>> Subject: Excluded List for "#size-cells" warning
>>>>> Date: Tue, 28 Oct 2025 10:00:25 -0600
>>>>> From: Stan Johnson <userm57@yahoo.com>
>>>>> To: debian-powerpc@lists.debian.org
>>>>> CC: Finn Thain <fthain@linux-m68k.org>, Christophe Leroy
>>>>> <christophe.leroy@csgroup.eu>
>>>>>
>>>>> Hello,
>>>>>
>>>>> On a PowerBook G3 Pismo running the latest Debian SID, dmesg 
>>>>> reports the
>>>>> warning shown below. I've also seen the warning on PowerBook 
>>>>> Lombard and
>>>>> Wallstreet systems. I haven't checked PowerBook 3400c or Kanga.
>>>>
>>>> Can you send me a dump of the device tree on these systems:
>>>>
>>>> dtc -O dts /proc/device-tree
>>
>> Please see the attached compressed files containing dtc output for a 
>> Wallstreet (dtc_wallstreet.txt) and a Pismo (dtc_pismo.txt).
>>
>>>>
>>>> We've been fixing up these cases such as in commit 7e67ef889c9a
>>>> ("powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7")
>>>
>>> And of course it is perfectly fine for an actual Open Firmware to *not*
>>> repeat the defaults.  As the documentation (the main IEEE 1275 thing)
>>> says: "A missing “#size-cells” property signifies the default value of
>>> one."  There are many other places in OF geared towards this default
>>> btw, take for example the "reg" word, that silently assumes your node's
>>> #size-cells is 1, and does completely the wrong thing if not.
>>>
>>> Flattened device trees are a fine thing, but the gratuitous ways it
>>> differs from OF, are not.
>>>
>>>
>>> Segher



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Excluded List for "#size-cells" warning
  2025-12-08 16:25           ` Stanley J. Johnson
@ 2025-12-08 16:29             ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2025-12-08 16:29 UTC (permalink / raw)
  To: Stanley J. Johnson, Michael Ellerman, Madhavan Srinivasan
  Cc: Segher Boessenkool, linuxppc-dev, Finn Thain

On Mon, Dec 8, 2025 at 10:25 AM Stanley J. Johnson
<stanley.j.johnson.001@gmail.com> wrote:
>
> Hello,
>
> Please let me know if you have any information regarding this issue.

The fix[1] which I CC-ed you on is waiting on the PPC maintainers to pick up.

Rob

[1] https://lore.kernel.org/all/20251029174047.1620073-1-robh@kernel.org/

>
> thanks
>
> -Stan Johnson
>
> On 10/30/25 4:14 PM, Stan Johnson wrote:
> > Attached are the dtc output files for a PB Lombard and a PB 3400c. If
> > you need any other information, please let me know.
> >
> > Thanks for looking into this.
> >
> > -Stan Johnson
> >
> > -----
> >
> > On 10/29/25 11:00 AM, Stan Johnson wrote:
> >> On 10/29/25 1:29 AM, Segher Boessenkool wrote:
> >>> On Tue, Oct 28, 2025 at 08:17:27PM -0500, Rob Herring wrote:
> >>>> On Tue, Oct 28, 2025 at 7:05 PM Stan Johnson <userm57@yahoo.com> wrote:
> >>>>>
> >>>>> -------- Forwarded Message --------
> >>>>> Subject: Excluded List for "#size-cells" warning
> >>>>> Date: Tue, 28 Oct 2025 10:00:25 -0600
> >>>>> From: Stan Johnson <userm57@yahoo.com>
> >>>>> To: debian-powerpc@lists.debian.org
> >>>>> CC: Finn Thain <fthain@linux-m68k.org>, Christophe Leroy
> >>>>> <christophe.leroy@csgroup.eu>
> >>>>>
> >>>>> Hello,
> >>>>>
> >>>>> On a PowerBook G3 Pismo running the latest Debian SID, dmesg
> >>>>> reports the
> >>>>> warning shown below. I've also seen the warning on PowerBook
> >>>>> Lombard and
> >>>>> Wallstreet systems. I haven't checked PowerBook 3400c or Kanga.
> >>>>
> >>>> Can you send me a dump of the device tree on these systems:
> >>>>
> >>>> dtc -O dts /proc/device-tree
> >>
> >> Please see the attached compressed files containing dtc output for a
> >> Wallstreet (dtc_wallstreet.txt) and a Pismo (dtc_pismo.txt).
> >>
> >>>>
> >>>> We've been fixing up these cases such as in commit 7e67ef889c9a
> >>>> ("powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7")
> >>>
> >>> And of course it is perfectly fine for an actual Open Firmware to *not*
> >>> repeat the defaults.  As the documentation (the main IEEE 1275 thing)
> >>> says: "A missing “#size-cells” property signifies the default value of
> >>> one."  There are many other places in OF geared towards this default
> >>> btw, take for example the "reg" word, that silently assumes your node's
> >>> #size-cells is 1, and does completely the wrong thing if not.
> >>>
> >>> Flattened device trees are a fine thing, but the gratuitous ways it
> >>> differs from OF, are not.
> >>>
> >>>
> >>> Segher
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-12-08 21:19 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <70d76dcf-c7d4-43c5-c169-07054a37195c@yahoo.com>
2025-10-28 23:55 ` Fwd: Excluded List for "#size-cells" warning Stan Johnson
2025-10-29  1:17   ` Rob Herring
2025-10-29  7:29     ` Segher Boessenkool
2025-10-29 17:00       ` Stan Johnson
2025-10-30 22:14         ` Stan Johnson
2025-12-08 16:25           ` Stanley J. Johnson
2025-12-08 16:29             ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).