Re: [PATCH 3/3] ASoC: fsl_asrc_dma: allocate memory from dma device

Shengjiu Wang
2026-01-29T09:37:54Z

On Thu, Jan 29, 2026 at 5:22 PM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>
> On 1/28/26 09:18, Shengjiu Wang wrote:
> > As the dma device may support dma-coherent property on the i.MX952,
> > allocate memory from dma device to make asrc driver to be compatible with
> > such a case.
>
>
> This commit message refers to imx952 but the change in the code apply to all supported platforms
>
> So in not really clear what is the intention of it.

The dma-coherent property is used to indicate a device is capable of
coherent DMA operations.
Which is applied to the EDMA device on i.MX952, in order to support
such EDMA device,
the memory is need to allocated from DMA device,

The code change is compatible for non dma-coherent and dma-coherent dma devices.

>
> Also, it is not clear why do you allocate a pair only to free it at the end of the function.

As the comment in the code says, it is to get the dma device handler
for memory allocation
. After that, it is freed.

best regards
Shengjiu wang
>
>