From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37707EDF17D for ; Fri, 13 Feb 2026 16:29:00 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fCHfr5WG8z2xN7; Sat, 14 Feb 2026 03:28:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1771000132; cv=none; b=muOrZnosUd6auPhWa1tii/Ne95Kmy/tT1JGKwx4yO8tNDxhgaN8EuE2iwA8mxL4l0qKasKhQVQ1Dc/KaZr4vvUGFndc15Zuu2/F8BG4QDVly7upIX6RWeSZ/4cKAvuDHL5cVglKxlb6quJjwP06gpB6TJg8V5myjKEOYU2CavLFLISzV6IwjeGPZxYJbgXc4BpK3dwh2PdjHwZolkmRULKxtUwZ6TH7x5UGC2XbWDYh3l5UXOwC2rzKZ1Gt/Hqhvj3dyluHg0rsdlTjSYapDCbi9hc0o7lIDw6Z4OxDCW7+97H6OC21I18dy+g47KVadmscpzAZiVLugZu1BcE/yZA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1771000132; c=relaxed/relaxed; bh=ItyPigPLcK1ublvyrUssoUkA037eYFbFHfziLXQ8Zz4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZRbU3/w+V7gzsP0w8B/Gr2ls1e5l5wuoUxS0vyEQ7foBbQS93/BAeqaKJrgRwsHBu39IGyfXSRC/G+XopyVuwfBZxzrNAudtpbfBRW6o6v0wcGiPx6LMAfpqTu6etLS4gBrEWSJUP8sb96BwBNOz0ZTawWaRyh2i0Mh2aEM7K6BbL9pDsDM9foN5UJMnQJVlaaGY+tzEj5nZDKAqAWDHpNE31U+pWVCEmZ57cc3dGTCTRHfQyPWMHurAKTWtRO8aLe8z0/ZxGRafcFUuRf22IGBGPh1sqOXXK+/ayO/GzNoPEXU+h66vS81ctyf564asLhFEIWGrQxLXUzbhRLLO6Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=LsnOws9q; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=nsc@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=LsnOws9q; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=nsc@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fCHfq68W7z3bf4 for ; Sat, 14 Feb 2026 03:28:51 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BF9EE4456E; Fri, 13 Feb 2026 16:28:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6DE2C116C6; Fri, 13 Feb 2026 16:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771000129; bh=Is8B/gAp14/MAcFbg96ZIgqDeyXZZUZIPxoz/Mhgjws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LsnOws9qOYK9BK+e43Z10TNiZYYnSMw0ragyjrqS86ru8HCDfTHQvr6xnLjVukd5A vXPZZtp9dSwRki4+yTsVpohKYfrptdvspvAhStd1mM6VdDrHMIrbFNgC2sZtG+7Phh 2DuFk0Nh1Vk6hFXUKGeqgAKvVk0BpI/lrh9YCeSwTe2j7ZgXMzUb59FKJsqTPQHd+I IshzYTj4pOMJ+/F6ynT0fZevQw3dXRr/bSP0yLXywyV/U6IU+njUT3lpWem2kovUgc DBeAecVActHylnElyeJ466SHK5tx2ccvewQDcvErlQMk0AqDNjQXKXBQuvUTAn/wZ/ J1UsBRCwK/x2g== Date: Fri, 13 Feb 2026 16:14:04 +0100 From: Nicolas Schier To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Fabian =?iso-8859-1?Q?Gr=FCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?iso-8859-1?Q?C=E2ju?= Mihai-Drosi , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v4 11/17] module: Move lockdown check into generic module loader Message-ID: Mail-Followup-To: Nicolas Schier , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Fabian =?iso-8859-1?Q?Gr=FCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?iso-8859-1?Q?C=E2ju?= Mihai-Drosi , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org References: <20260113-module-hashes-v4-0-0b932db9b56b@weissschuh.net> <20260113-module-hashes-v4-11-0b932db9b56b@weissschuh.net> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260113-module-hashes-v4-11-0b932db9b56b@weissschuh.net> On Tue, Jan 13, 2026 at 01:28:55PM +0100, Thomas Weißschuh wrote: > The lockdown check buried in module_sig_check() will not compose well > with the introduction of hash-based module validation. > Move it into module_integrity_check() which will work better. > > Signed-off-by: Thomas Weißschuh > --- > kernel/module/main.c | 6 +++++- > kernel/module/signing.c | 3 +-- > 2 files changed, 6 insertions(+), 3 deletions(-) > Reviewed-by: Nicolas Schier