From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,
nicoleotsuka@gmail.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: fsl_sai: add bitcount and timestamp controls
Date: Fri, 6 Feb 2026 14:37:30 +0000 [thread overview]
Message-ID: <aYX8qnKiPxHej-Xo@sirena.co.uk> (raw)
In-Reply-To: <20260206084334.483404-2-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Fri, Feb 06, 2026 at 04:43:33PM +0800, Shengjiu Wang wrote:
> + SOC_ENUM("Transmit Timestamp Increment", tstmp_enum[0]),
Don't have arrays of enums with magic indexes into them - this is just
error prone and hard to follow. The normal thing is to declare a
separtae variable for each enum, or if you *must* use an array use
named constants at both ends to index into it (but that's not
meaningfully different to just having multiple variables...).
> + SOC_SINGLE("Transmit Timestamp Reset", FSL_SAI_TTCTL, __bf_shf(FSL_SAI_xTCTL_RTSC), 1, 0),
> + SOC_SINGLE("Transmit Bit Counter Reset", FSL_SAI_TTCTL, __bf_shf(FSL_SAI_xTCTL_RBC), 1, 0),
__bf_shf()?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-02-06 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 8:43 [PATCH 0/2] ASoC: fsl: add bitcount and timestamp controls Shengjiu Wang
2026-02-06 8:43 ` [PATCH 1/2] ASoC: fsl_sai: " Shengjiu Wang
2026-02-06 14:37 ` Mark Brown [this message]
2026-02-09 3:16 ` Shengjiu Wang
2026-02-10 3:09 ` Shengjiu Wang
2026-02-06 8:43 ` [PATCH 2/2] ASoC: fsl_xcvr: " Shengjiu Wang
2026-02-06 16:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYX8qnKiPxHej-Xo@sirena.co.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox