From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 872DDEE20A8 for ; Fri, 6 Feb 2026 14:37:53 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4f6xX00h3Mz2xqk; Sat, 07 Feb 2026 01:37:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770388672; cv=none; b=EuW9gKEQSGlaLQKEpcWoVajy2RpRTkD3t7HZL0LPPW2dlJ9jGtkPkIygtxnSCuhTXMhBvdw1sVUkWXSQdjPB1MNbPO/k/+GkfxBAlp2bh7uJgeMV8yqbkhs+MOuTjAFq2d04ZFT1uyrw0DMoik9ep6EueJjXX4mDCiXQTAy0jOF1KCAnyYTedsIygrLQ39BOUipSyVfEpz57I3jHuNKVWjChCrIyuNClU9j45AsctrY5q62zSj5VxWX22oXd0PI+iNsW1PnRRHDTmRXJ4fquF6px6XH8RKlvzbLgiMwOVRCCL2dh+sDtEChHOuBMbqA57rxQregMZNIwJ7eR89I5bw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770388672; c=relaxed/relaxed; bh=6gGXh+kLbZ7AK2NVMrvL1ivH+8pNxuKEB4lGyvqc3iM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ACc2fmyTgtgpzQQIVWf72nFvSBSGDY6dC0wX5hkxzuvehK+5ez93JlpF6/hMPy4D4QZn4+LphvGLmHK5w9S7QRdz2QuwKMK46aH7VSjZ29GAQnU9zi4IinmaiBuj/f9Ow27PhcJrqvo9OiIgWwWo8qgVw7KEgRZ1V3+p9iDGm6tskTTESDZlt96gVd6XJ+zif4Et5rXNdMZEztiBAkLrinryhWbc4dOnb76+vFFI8nX7TutoeqTyvG73br/XXtrO1L+smXyrTWWS8YfDGQqM2vlIofXa8tZP2C1P+xTwdCnT5UrIPM4XinBFKnj9qLhriBLG+P3DZayboG3YpZlwUg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fTApNlbH; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=broonie@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fTApNlbH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=broonie@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4f6xWz2sQXz2xpg for ; Sat, 07 Feb 2026 01:37:51 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8899140605; Fri, 6 Feb 2026 14:37:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A47BC116C6; Fri, 6 Feb 2026 14:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770388669; bh=Jb40v8mY4M7tTNZXeR7aVTdPQb1xvqpEjVIz9gC7w30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fTApNlbHQajRJxUlp3PS9vUGXFC1v/0fN2X1ol3nL/kZdnHl7UklO7cwosQ5LDnVe 0CI+sdQg2ArK/yn7uYHIf0HB9NzLe/w6LIlI8UhpoUdhtfp/P/GUKwKrX9sYM0+oir XI+K7FEOQsKr4fXY215UOONyDh711Cbz7GkHkRPvBDxfOLUTv53OUsa53eveBM/+FN OJf81TyuWlJd0/eFbaO4JLgZdk4F1fzSA1OGr6ksV1YPPaxMUouq80yBI8/aO+6XPG yvTFNG3h0LaFrDd3sTwUKSGnfP9WM+dCA/UpGwJpXdSe+21wN1OqOxGH+RafcguHbd yfZEBy+VoJqrg== Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id E78FE1AC57C7; Fri, 06 Feb 2026 14:37:30 +0000 (GMT) Date: Fri, 6 Feb 2026 14:37:30 +0000 From: Mark Brown To: Shengjiu Wang Cc: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ASoC: fsl_sai: add bitcount and timestamp controls Message-ID: References: <20260206084334.483404-1-shengjiu.wang@nxp.com> <20260206084334.483404-2-shengjiu.wang@nxp.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4U4VAjC1uItOIZh0" Content-Disposition: inline In-Reply-To: <20260206084334.483404-2-shengjiu.wang@nxp.com> X-Cookie: Think big. Pollute the Mississippi. --4U4VAjC1uItOIZh0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 06, 2026 at 04:43:33PM +0800, Shengjiu Wang wrote: > + SOC_ENUM("Transmit Timestamp Increment", tstmp_enum[0]), Don't have arrays of enums with magic indexes into them - this is just error prone and hard to follow. The normal thing is to declare a separtae variable for each enum, or if you *must* use an array use named constants at both ends to index into it (but that's not meaningfully different to just having multiple variables...). > + SOC_SINGLE("Transmit Timestamp Reset", FSL_SAI_TTCTL, __bf_shf(FSL_SAI_xTCTL_RTSC), 1, 0), > + SOC_SINGLE("Transmit Bit Counter Reset", FSL_SAI_TTCTL, __bf_shf(FSL_SAI_xTCTL_RBC), 1, 0), __bf_shf()? --4U4VAjC1uItOIZh0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmmF/KcACgkQJNaLcl1U h9Ds6wf/YWaxs5YOsfGQrXDpwAs4yUlLFDh7y71lDdgia/JOhB8hzK0DcB/7IIm1 LLdfmXH7FtIoJRSC7vnsb5Z0aGZHs2K/uiD4qBt5GIvJO5tB710tCR8I+g69wQiB ojaYxQHlF4OOIz+NOoWCaBUtJUEbMaEPntJtL9gmeCWYgFyYXvXFk1zmcpdyYCWy O3IDrXOlJF66o88YNwtQzlNfrBLnMNMAoP1gdZaEA5ffpb0y5f6nT22UzKmTBMYD m59LPLxxlCP73/Kre6gxR0PuRoMCyNn0vrPwgfG3BE/1QjXzhdO4fS3aSCUEewJw 1sHHbF7Jn2kP525HIOYPoPgm9hhErg== =XqPH -----END PGP SIGNATURE----- --4U4VAjC1uItOIZh0--