From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82144EE6B60 for ; Fri, 6 Feb 2026 21:11:05 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4f76Ff3M8kz2xC3; Sat, 07 Feb 2026 08:11:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=83.223.78.240 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770412262; cv=none; b=fT2N412GB3VSH6oYIKrbWJElTY4tyndHO44FFVroULd3+hQNkwkk9xiaNQrIxx8YwJ2/t6QZnqmgWpY0Xq8U5htsX/5Yw8y87vxvh7W2ic12O/YJHTrvEaBHNMfcCSdIot6n7MWZQXClMMcOfY2ubqYMQ2EdLg5KIsSHcgfcl/kgQQ41IVEQhQTHOVXRYmJJWKhFHFi7YuUSTaqHx6ngPpONLrOSj8DDARw6DPemMp/exxPX21fsQQzAAkpW5urbSsmCzRIcSWcI6mlXQ2Td1DGSARExbaSoUsPJzM/fVU1D4fRvI6TQoRfPagZLh73vNO+LbzX/cI44vcQMcVl1Qg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770412262; c=relaxed/relaxed; bh=mz1qbjBAzYoHdpr/Nta6rs4B8XNVt+UNtvznF5azaYA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WfQzkjR1nJv7pd680590mFzLUQqDnNflqZg72Z2G432Ju+9PKnwscmBBM77icbnykA/GqDMRMC6tjls1cDBSRAZLpRgYb0/kHhdPYR6ZKkrA6mqj4v3hp1m+6Rp5rIJOt2VhtpUN+WErU8JKb0RFlybPCyJrJaIKmV/Ny3c0UVAMzAD1WHA1n7gcC/LnRISOYV0uD9je0sMa3M1y5JSkGKMIP4bGzRV0UpOHDg+LWEh/sAxqZl+59b+AzGPrIUyF6bxZfdPdZWI0tOqhzKRL2YdZiVRU3NxzSbHekfhvXUh6LsmCRanycVB8ch9S7bmOqaO9zuPAUsinXhiiserS9Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=pass (client-ip=83.223.78.240; helo=bmailout2.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver=lists.ozlabs.org) smtp.helo=bmailout2.hostsharing.net Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=bmailout2.hostsharing.net (client-ip=83.223.78.240; helo=bmailout2.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver=lists.ozlabs.org) Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4f76Fd444Vz2x99 for ; Sat, 07 Feb 2026 08:11:01 +1100 (AEDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 246912008014; Fri, 6 Feb 2026 22:10:48 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 1F9F0473B; Fri, 6 Feb 2026 22:10:48 +0100 (CET) Date: Fri, 6 Feb 2026 22:10:48 +0100 From: Lukas Wunner To: Keith Busch Cc: Bjorn Helgaas , Breno Leitao , Jonathan Corbet , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, dcostantino@meta.com, rneu@meta.com, kernel-team@meta.com Subject: Re: [PATCH] PCI/AER: Add option to panic on unrecoverable errors Message-ID: References: <20260206-pci-v1-1-85160f02d956@debian.org> <20260206185232.GA70936@bhelgaas> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 06, 2026 at 09:53:39PM +0100, Lukas Wunner wrote: > So I wouldn't consider 918b4053184c to have been a universally successful > approach and I fear that this patch goes even further. Forgot to mention -- there's another problem: PCI_ERS_RESULT_NO_AER_DRIVER is obviously AER-specific. powerpc (EEH) and s390 have error recovery mechanisms separate from AER and we've been trying to align them more closely so that drivers don't need to be aware of platform-specific behavior. eeh_pe_report_edev() does not modify the pci_ers_result for unbound drivers and those without pci_error_handlers. And the default is PCI_ERS_RESULT_NONE. eeh_report_error() also returns PCI_ERS_RESULT_NONE for drivers without ->error_detected() callback. In the PCI_ERS_RESULT_NONE case, EEH seems to perform a reset and assume successful recovery. It's only AER that is this strict about unbound devices and drivers that lack pci_error_handlers. If anything we should try to *reduce* deviations between the various error recovery mechanisms, not double down on increasing them. Thanks, Lukas