From: Lukas Wunner <lukas@wunner.de>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, bhelgaas@google.com,
kbusch@kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com,
mahesh@linux.ibm.com, oohall@gmail.com,
Jonathan.Cameron@huawei.com, terry.bowman@amd.com,
tianruidong@linux.alibaba.com, zhuo.song@linux.alibaba.com,
oliver.yang@linux.alibaba.com
Subject: Re: [PATCH v2] PCI/AER: Only clear error bits in PCIe Device Status register
Date: Wed, 11 Feb 2026 13:34:27 +0100 [thread overview]
Message-ID: <aYx3Uy7rE6GM9xq-@wunner.de> (raw)
In-Reply-To: <20260211054816.22758-1-xueshuai@linux.alibaba.com>
On Wed, Feb 11, 2026 at 01:48:16PM +0800, Shuai Xue wrote:
> +++ b/drivers/pci/pci.c
> @@ -2243,10 +2243,11 @@ EXPORT_SYMBOL_GPL(pci_set_pcie_reset_state);
> #ifdef CONFIG_PCIEAER
> void pcie_clear_device_status(struct pci_dev *dev)
> {
> - u16 sta;
> -
> - pcie_capability_read_word(dev, PCI_EXP_DEVSTA, &sta);
> - pcie_capability_write_word(dev, PCI_EXP_DEVSTA, sta);
> + pcie_capability_write_word(dev, PCI_EXP_DEVSTA,
> + PCI_EXP_DEVSTA_CED |
> + PCI_EXP_DEVSTA_NFED |
> + PCI_EXP_DEVSTA_FED |
> + PCI_EXP_DEVSTA_URD);
Isn't there one too many blanks before each of the PCI_EXP_DEVSTA_* macros?
The available space would be sufficient to accommodate two macros per line,
so just 2 instead of 4 lines for the macros.
Otherwise this is:
Reviewed-by: Lukas Wunner <lukas@wunner.de>
next prev parent reply other threads:[~2026-02-11 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 5:48 [PATCH v2] PCI/AER: Only clear error bits in PCIe Device Status register Shuai Xue
2026-02-11 12:34 ` Lukas Wunner [this message]
2026-02-11 12:42 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYx3Uy7rE6GM9xq-@wunner.de \
--to=lukas@wunner.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=oliver.yang@linux.alibaba.com \
--cc=oohall@gmail.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=terry.bowman@amd.com \
--cc=tianruidong@linux.alibaba.com \
--cc=xueshuai@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox