From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB31C433E0 for ; Thu, 18 Mar 2021 02:38:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 080FD64EE1 for ; Thu, 18 Mar 2021 02:38:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 080FD64EE1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F1B5j6sL8z3bxy for ; Thu, 18 Mar 2021 13:38:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.35; helo=szxga07-in.huawei.com; envelope-from=heying24@huawei.com; receiver=) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F1B5M2tlgz2yRy for ; Thu, 18 Mar 2021 13:37:41 +1100 (AEDT) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F1B312bPkz90G6; Thu, 18 Mar 2021 10:35:41 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Thu, 18 Mar 2021 10:37:26 +0800 Subject: Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings To: Michael Ellerman , Daniel Axtens , , , , , , , , , References: <20210316041148.29694-1-heying24@huawei.com> <87wnu6bhvi.fsf@dja-thinkpad.axtens.net> <87tupab4a1.fsf@dja-thinkpad.axtens.net> <877dm6ouw5.fsf@mpe.ellerman.id.au> From: "heying (H)" Message-ID: Date: Thu, 18 Mar 2021 10:37:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <877dm6ouw5.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: johnny.chenyi@huawei.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" 在 2021/3/17 19:57, Michael Ellerman 写道: > Daniel Axtens writes: >> "heying (H)" writes: >> >>> Thank you for your reply. >>> >>> 在 2021/3/17 11:04, Daniel Axtens 写道: >>>> Hi He Ying, >>>> >>>> Thank you for this patch. >>>> >>>> I'm not sure what the precise rules for Fixes are, but I wonder if this >>>> should have: >>>> >>>> Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses") >>>> Fixes: f79643787e0a ("powerpc/64s: flush L1D on kernel entry") >>> Is that necessary for warning cleanups? I thought 'Fixes' tags are >>> needed only for >>> >>> bugfix patches. Can someone tell me whether I am right? >> Yeah, I'm not sure either. Hopefully mpe will let us know. > It's not necessary to add a Fixes tag for a patch like this, but you can > add one if you think it's important that the fix gets backported. > > I don't think the cleanups in this case are that important, so I > wouldn't bother with a Fixes tag. Okay. That's a good explanation to me. Thanks.