From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2612E9B354 for ; Mon, 2 Mar 2026 10:01:19 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fPZFp2FvBz3bn4; Mon, 02 Mar 2026 21:01:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a00:1450:4864:20::34a" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772445678; cv=none; b=V1Wpi7iMtCDEU4GMtSFjcBnO0tmdZbOUE8G01pbpwdF3tS3xXOQkmCKl1ndwTbhcYla2iBOEFo1/Cyzj5gC2we6BpN4ze1jlGoPppdxqpWSlM9QIZ+2/CwnNsMvHSVEyKPRP8Bk3DBt4/UDL4MbtlP1/mG2nuSMMKlnzj08jLWbS7mMUtI1XxzuEejxFU/VlwaH6n3eGoP7/GELPFgWwbrP6uSyziwFLbQDsFvyguCw2yDIk4ZJyov7rQmmr8pP0fL6GNjYYqx5mYxhI0kOB3JfYG3OKB1GEzb9E3wAiof4XS0JIhcwCO+oKIAQJByR5kMkU5QwgbJqqe/GgBPxPpw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772445678; c=relaxed/relaxed; bh=tjS8FX592qmj/rFkafjn+lojx6cnlsSGWxK3ppaLTGU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=okFs156yk54GzQ6rROLGCwZ30/bsm9tHM5h7fjwmishp7WHX8nlQbQiP8LVEBPBQhWeNRwkXsvZgPi1BHRPTPTAb2A16roGDPaYh0U7ddVqXto6RvtymmBliwdfhxj40BDMWNrkDmKp97GDHXYzFqZoWk2B2MQpgPeBI7KRbz8YgI3+FF01Qa4iUJLiQhNOrYS4dNhuyR5zjZLJDjsWpStzi0OqgF89rC1U/wwEYrAY1cAZ7ujfjuxC7sEk+sGErkY3+x/Xzhin17mA4cHI9kbZek61T1zTROoN2nHVrVoYej8hqv0lUSs9DTMK7cOQrSQx8+apPwGkTWsRzEy4FIg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=PGHmtHtH; dkim-atps=neutral; spf=pass (client-ip=2a00:1450:4864:20::34a; helo=mail-wm1-x34a.google.com; envelope-from=351-laqkkdjau52wybi1508805y.w86527eh99w-xyf52cdc.8j5uvc.8b0@flex--aliceryhl.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=PGHmtHtH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--aliceryhl.bounces.google.com (client-ip=2a00:1450:4864:20::34a; helo=mail-wm1-x34a.google.com; envelope-from=351-laqkkdjau52wybi1508805y.w86527eh99w-xyf52cdc.8j5uvc.8b0@flex--aliceryhl.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-wm1-x34a.google.com (mail-wm1-x34a.google.com [IPv6:2a00:1450:4864:20::34a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fPZFm1k7Kz2xGF for ; Mon, 02 Mar 2026 21:01:15 +1100 (AEDT) Received: by mail-wm1-x34a.google.com with SMTP id 5b1f17b1804b1-4806b12ad3fso35537565e9.0 for ; Mon, 02 Mar 2026 02:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772445672; x=1773050472; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tjS8FX592qmj/rFkafjn+lojx6cnlsSGWxK3ppaLTGU=; b=PGHmtHtH8dhadVmsawUX8GYsMm8sKjWbtjM0f0wN4Po7mcWsH0Eh+YXzuFz8Maum11 YiLYG7c6JevWsK3pw318wYziA/RYpAI6kbNQ9wXKBKL+LC+NMWZBF+e3kZcjlZ7QPldU K78IhEsQ0wvY9SDOAcUR5Be8ds3H8bO0w6PXP/PaaLywDsCH+bfLlZLfEKF6fSBA1rLC nDrKz3SRDnvhpS16UCYoFqrwCmtBjj52cA8X0NjmlXzohxxXIpC0UV5Dg8fgdPaxCp3T 8bw75cY1s/xftLq040KkdhJPrU6+xa6oPGhmGca8pWmdtezXFjOOgzV09WiiHyH+Y+Yc 6IIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772445672; x=1773050472; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tjS8FX592qmj/rFkafjn+lojx6cnlsSGWxK3ppaLTGU=; b=VI2ukQurt4tSeXOTvs87upQZDKFlDQqs//Sm5cVVdsdYcyW/FOXPNmYGGsnRvKnu7o m3xghqiZ69m12nctMyykBWDodX0ZELxWIFLXrvnh3+vxyxJyYermNABp78SygAfLmIAJ x3jec5akdsV0hoGc5ay8snEUxDSWOgAVFb64Eyi7FK+fddWiFBnBIiVdfuO67+vufHLc uDPkbEC4ZCkbX6PYKw2bXFeklBATuZVKSriIfgh2KwIrSY13SLXwce1pTE9DkmJFN0jl aDpadJIuntbO/xKm4lHp6kOXf34vdpO13NJeXv0c9YpptscNn79ziU94YHshoXX8mtl9 pYEQ== X-Forwarded-Encrypted: i=1; AJvYcCVL2mm2qds1PHPM1P0e+HqItYKzkKxlNhf0SFdgJ0KkZQ45Yx1pjZHeKH6fihsedRKuCbEyMeuAWHcWO7g=@lists.ozlabs.org X-Gm-Message-State: AOJu0Yx3iLaHv5qB+Vzg4VsG1Bnd8LkIouq8n4GLUlu23K6DlBo7cFov 6GhSTozfscFUhCfR/o6FEtEkNfOWH8Kcpbx/x6Oq8nRLg05FFoiTYyGLtLzSla/e6HMFnSiXQIN I/ZqWg71drS6EqPNlZg== X-Received: from wmbg9.prod.google.com ([2002:a05:600c:a409:b0:483:7827:ade4]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3110:b0:480:2521:4d92 with SMTP id 5b1f17b1804b1-483c9c23ffbmr196674855e9.24.1772445671732; Mon, 02 Mar 2026 02:01:11 -0800 (PST) Date: Mon, 2 Mar 2026 10:01:10 +0000 In-Reply-To: <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Mon, Mar 02, 2026 at 09:18:45AM +0100, David Hildenbrand (Arm) wrote: > On 2/28/26 13:38, Alice Ryhl wrote: > > On Fri, Feb 27, 2026 at 09:08:33PM +0100, David Hildenbrand (Arm) wrote: > >> Nobody except memory.c should really set that parameter to non-NULL. So > >> let's just drop it and make unmap_mapping_range_vma() use > >> zap_page_range_single_batched() instead. > >> > >> Signed-off-by: David Hildenbrand (Arm) > > > >> diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > >> index da21d65ccd20..b8e59e4420f3 100644 > >> --- a/rust/kernel/mm/virt.rs > >> +++ b/rust/kernel/mm/virt.rs > >> @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, size: usize) { > >> // sufficient for this method call. This method has no requirements on the vma flags. The > >> // address range is checked to be within the vma. > >> unsafe { > >> - bindings::zap_page_range_single(self.as_ptr(), address, size, core::ptr::null_mut()) > >> + bindings::zap_page_range_single(self.as_ptr(), address, size) > >> }; > > > > Please run rustfmt on Rust changes. Here, rustfmt leads to this being > > formatted on a single line: > > Having to run tooling I don't even have installed when removing a single > function parameter; did not expect that :) Well, rustfmt comes with the compiler, and it would be ideal to build test changes before sending them :) But no worries, I took care of testing it. Thanks for taking the time to update the Rust code as well. Documentation/rust/quick-start.rst has details for most distros. Alice