From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 375FFE9B359 for ; Mon, 2 Mar 2026 10:33:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fPZzL5mD2z2xc8; Mon, 02 Mar 2026 21:33:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a00:1450:4864:20::349" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772447630; cv=none; b=kISwYzuJT4D3ge8TA7w4XY9THTAF53/IoomTLbkLIEiO3scwJDibHak+mMWWknCqsccyCmWZIwd2vE0gEiZag8o4hYqf08eYO+lg8O7PL9QqhSuliUmiPs1cMDeftv9mi0ll00iqFPaPWKOQe23cjuIyOAoau9R7NqfMzkn3Dnc4f/GHjLe19Y/IhYhqOb2qizinv/jvJaMQiVsw0MYejXIam/zaXWiWEklW25Dy22NbuxN9P1hTexsQM5gol0g4eJCCZaOX07AeiPcFhKbzAQwUQflHsqxxbi4HpceKH6vQPRX7zD8tDFsEwDxveeeWnwnDD2lP0pipwUjQbqoApw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772447630; c=relaxed/relaxed; bh=EnMgJMcaQgCDj7i00Uawlj/G1rJtXPwe1sCLwvhoFHI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=gkWG84c3KWvwfB+/zh43ATfGFPMtc2MKbz2owvOta9QvrbEQtwjlGBhG32eJcYTzUuRww0eUA5mUgc3eJOQwy6idzWR2S8zpE+yYYVUA0vSlahXwm4+gSAnFnT+rgeCkqoVOn9XRu5j1VdfeTgWuqqfCUd5CYAPaXNUz62V08lEcgkD8UHOPgMZUDcoxBUI48NUpwTtrsY2e6yk+tnc6TeullBFeqjLnPVu2ToyrCkWpNgSWLU4WB0SLUvgWq4wpAD1vqxjdMo2lzSYeYstU1ZtG3sJiMbl166c0u6U8qTBEFYszjQxQau6jmKkJ4B21RI3GuLY9175xgeCQIOm38g== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=beZEtrSc; dkim-atps=neutral; spf=pass (client-ip=2a00:1450:4864:20::349; helo=mail-wm1-x349.google.com; envelope-from=3iwelaqkkdeiepmgiv2lpksskpi.gsqpmry1ttg-hizpmwxw.s3pefw.svk@flex--aliceryhl.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=beZEtrSc; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--aliceryhl.bounces.google.com (client-ip=2a00:1450:4864:20::349; helo=mail-wm1-x349.google.com; envelope-from=3iwelaqkkdeiepmgiv2lpksskpi.gsqpmry1ttg-hizpmwxw.s3pefw.svk@flex--aliceryhl.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fPZzK5SRnz2xGF for ; Mon, 02 Mar 2026 21:33:49 +1100 (AEDT) Received: by mail-wm1-x349.google.com with SMTP id 5b1f17b1804b1-48378c4a79fso36135675e9.0 for ; Mon, 02 Mar 2026 02:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772447626; x=1773052426; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EnMgJMcaQgCDj7i00Uawlj/G1rJtXPwe1sCLwvhoFHI=; b=beZEtrSc3j8uDa2QX7+B7taeSf3XYNt8Ie3DXxLj2Gp6TRgoc4FqTDb+ShQ/eFs4E/ DbSdp/Rmi/JSiyRsVu3Ko/gVEf2MG0O+67sHfmM7MbkP3olR8J8ggQ4a8bPNvwGiRRYT 6auHBbr3ijI17a3YRCD+p1nnCBY7bVxB9ejq7+0U7G0qQPPChj1b8aFAe2xcLx0/QFxk r/KPrnUKUTktEfMPrpM01Jm5yZdy7xLOkgLkocx2faINY+K8xI1zZxOsyr0KeD9+SSXs /F3B3fjZhVUlsrbAVbJGJXDv17ZUoqcsSmWuow24lMYkfETtqJt0Kqx8pFq4CPPyL0ya wixw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772447626; x=1773052426; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EnMgJMcaQgCDj7i00Uawlj/G1rJtXPwe1sCLwvhoFHI=; b=iQ1EGFdfCKET92Lvc6723Ep9CIMEn/XXWxgE1Th4XteDVhD8nHfNnyNO5EFEbcPTd0 xStFAMsRK/Pa7gyJjqgOAh3d8AEx9jmFnxVsIh05DjXiCYc86Su3JoTrZNAg+YIoXHoJ 8vJOZac6ejlEzQFCd0eC/st+uj2xCwLGRc34k62ngCJGuxK3vF6kgTqtlf+gQTxw5GH1 A5EvyMbMLLMBnd46RaIQPSBedqfwBMIGMzhFQRLvehadX4gtO0u3Du5EG7Wsgv1rhmdv WJzAuAcVc3rE9yx8IRqd6tnMgseOI69miLIEYrDCaGwz2Eb3+1d5+vGaBIzEpcdp+4/5 KKNA== X-Forwarded-Encrypted: i=1; AJvYcCVvbVrhCw6L8TYMSbTVk/3Z/UYwgV3FqKTNW0GYkm3oCkNrHzVzkIbkaRwqXIos8dMOoSLz14o7G/6DImk=@lists.ozlabs.org X-Gm-Message-State: AOJu0YxbWNJ9eF7XW3FbX8vh8Ujr8dZsFQyM8xQJApZuwayXdlDZ9JsB PbWAS8GtBJfU+LnS8Axi7fpc3XV8MkGi7kz327ikKg/teqMc+pHxrVHXaUndTcGgnOZFDeGrf9q 76PM3YRalbiXRsuJkAA== X-Received: from wmdd1.prod.google.com ([2002:a05:600c:a201:b0:480:3227:a124]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6383:b0:47d:3ead:7440 with SMTP id 5b1f17b1804b1-483c9bdb683mr186031315e9.32.1772447625915; Mon, 02 Mar 2026 02:33:45 -0800 (PST) Date: Mon, 2 Mar 2026 10:33:45 +0000 In-Reply-To: X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Mon, Mar 02, 2026 at 11:27:40AM +0100, David Hildenbrand (Arm) wrote: > On 3/2/26 11:01, Alice Ryhl wrote: > > On Mon, Mar 02, 2026 at 09:18:45AM +0100, David Hildenbrand (Arm) wrote: > >> On 2/28/26 13:38, Alice Ryhl wrote: > >>> > >>> > >>> Please run rustfmt on Rust changes. Here, rustfmt leads to this being > >>> formatted on a single line: > >> > >> Having to run tooling I don't even have installed when removing a single > >> function parameter; did not expect that :) > > > > Well, rustfmt comes with the compiler, and it would be ideal to build > > test changes before sending them :) > > At least on Ubuntu on my notebook where I do most of the coding+patch > submissions it's a separate package? > > I do all my builds on a different (more powerful) machine where the > whole rust machinery's in place. Further, build bots that run on my > private branches did not report any issues. There are some build bots that check for rustfmt, though not all of them. > > But no worries, I took care of testing it. Thanks for taking the time to > > update the Rust code as well. > > I just did an allyesconfig and it does not report any warnings. > > So apparently, rustfmt problems not result in the compiler complaining? > > Or something else is off here that rust/kernel/mm/virt.rs won't get > compiled on my machine, even with allyesconfig. I can definitely see > some RUSTC stuff happening in the logs, like > > RUSTC L rust/kernel.o > > Thanks for the review and for pointing out rustfmt! Similar to kerneldoc and other similar targets, formatting isn't checked in the normal build, but make can be invoked on the rustfmtcheck target to check it. Alice