From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FC47EA4E26 for ; Mon, 2 Mar 2026 15:41:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fPjph5LTwz3bmk; Tue, 03 Mar 2026 02:41:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a00:1450:4864:20::349" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772466108; cv=none; b=h6nO/eqRsddYiUOdywpAn1X4J8D1jbuUE9i5qNoMvhFa+M0GQ6OFDCGhYkY5ldHgZwcvcKPnzUoRph5u73QTaJrcjIi//+gXL4qkGzE/ZXkItYsw7NNGE0UwfQ0lrddfmyC/PLF/H3PAvIBp2/hRys+UWqY9u51UpoFfzjySkAi/K4XTqndNWtxVtYlAIX1kaLS32GPlA1Db5FER4LyDa8MZBNXJte9Fv5szvBMQMnhlW8Jsv47nj8QRxKsfnRzzEBqR8o14mI8O0rr1bL4bt2KvIpdjFOXnrR/9hVLwJUOvogRNZzj5CIhNuJ5DLoxZGVIMbZe8urQr+oqNqjAQ/A== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772466108; c=relaxed/relaxed; bh=fvJ4Pj0Wo9ryI9xJ6mJ9OBJG9CVcmeBhutvadxQnZZs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=m5ZL2lFz+yUBQOxt1MCBNpSFq6b5Vk93j+lCwyS+GnsMgSj8NINO3hUIQpEsieAke5VNmG29e29piSvWrdAJ9nFS00Yef/7mDIexhjJ3ea45UCfQREB6EQbmSxtpgLrC3uFOfUCP7rPbaVBSEUb5QkJSgJELprdxVJaQBBzIPGrCBOLyO0DIhOLeQF2AvgL0G+JQ+FL7q774BDpJwwbfaMkh+MumvUlvBU4iQmTBXBD57trlj/IMYqli0x8njBKGsTLsgivIHRpJrX50BIkMFlDrxi2zqEIStBNpZHtulibZFzsiKo0XTowb+ZpPm73vxKqrJXVtCEUwe9xWZUrrnw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=TK/Twncz; dkim-atps=neutral; spf=pass (client-ip=2a00:1450:4864:20::349; helo=mail-wm1-x349.google.com; envelope-from=3tq-laqkkdaebmjdfszimhpphmf.dpnmjovyqqd-efwmjtut.p0mbct.psh@flex--aliceryhl.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=TK/Twncz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--aliceryhl.bounces.google.com (client-ip=2a00:1450:4864:20::349; helo=mail-wm1-x349.google.com; envelope-from=3tq-laqkkdaebmjdfszimhpphmf.dpnmjovyqqd-efwmjtut.p0mbct.psh@flex--aliceryhl.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fPjpg0XF3z3bmc for ; Tue, 03 Mar 2026 02:41:46 +1100 (AEDT) Received: by mail-wm1-x349.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso58425235e9.1 for ; Mon, 02 Mar 2026 07:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772466104; x=1773070904; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fvJ4Pj0Wo9ryI9xJ6mJ9OBJG9CVcmeBhutvadxQnZZs=; b=TK/TwncztJpDQkfAZOTLG4cnGFN1LJCasx8IcmzxYS0+EgQYgy73KBzi5ODnAZnFXU gTJXCTOyM9Gwu2ELr1NIa0zrho8Xxq7oT2FSeUP6yTgKB2PVWbyRIAP7SoFn5ZVIMq1i Rr7xFxWW2b6d55R0AnRNb7dmxRddmxaQqNqe/Vw3LXp4Qp4AJUczm+uty07PAFGqp/wW gNbxzwDfWdxGZOuIHOTRTfpDJPioNqXkeGLxgOOrSfVjT1vobTANjOjB+he0BhT8enG9 2r8VV7ygOrNrOq/T5e4JxxNkbRp54aLUTcasii+rJFC8NHy6KhTB+9uYC8BVdFVn7cGp AUIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772466104; x=1773070904; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fvJ4Pj0Wo9ryI9xJ6mJ9OBJG9CVcmeBhutvadxQnZZs=; b=PAiWfhm4nTU2FDRYnUmSoJSkCJfXfeKC1R2WXf5wIEe/Ee46NxFhEy/oWq7XNOnSMe J6szamTAfvwXLFwngwwgcCwzt9+tzP5aCTWVkJ0eVEYEE61NDkRgjxYEOQvdYdUdiNc5 J2oN0wLSMVsJQOsNmEVcDkrH9qdfJtJpqIpghBIwONPBeJpLZC1zTEMS/zFWK8Cqim2p EL2OE6C5aWThtEXxKvrq558PU0M/HGvZsdDVrTmSXpiES9ED93g30o12SR7ZMlcSUnKS zzuGIajhZSxOeFqiGUMyMelIC05weljvhY13V/m1Y6atwWC/iP+aKzDSevLaIC/dr4/m dOuw== X-Forwarded-Encrypted: i=1; AJvYcCX4VJNTYEeQpAfPjjoi2UcverTotLeG01BZTRx984/Xr5P/G5VrPM7zLM/KTR/u6ILM2J6aPrTVHS83Bt0=@lists.ozlabs.org X-Gm-Message-State: AOJu0YycQJCU0vC3CD5tAotfLiyVgtIA8WLkM/3eFNcSQ6iCvv5xoGRU 4rXoAUImwvNhjmvEbJAHxGU8UjiE6AM0N5FHo8588122AIi//OimXhzN3Zd1H5syWy5ebqXOzYP NAiNHWNa8O3EvfqAhzg== X-Received: from wmby19.prod.google.com ([2002:a05:600c:c053:b0:480:690c:88de]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b18:b0:483:7432:a761 with SMTP id 5b1f17b1804b1-483c9bc558bmr213622465e9.24.1772466102970; Mon, 02 Mar 2026 07:41:42 -0800 (PST) Date: Mon, 2 Mar 2026 15:41:42 +0000 In-Reply-To: <5f8dcb7f-9e4f-4484-b160-3a9ce541d63c@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> <5f8dcb7f-9e4f-4484-b160-3a9ce541d63c@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Mon, Mar 02, 2026 at 04:01:44PM +0100, David Hildenbrand (Arm) wrote: > On 3/2/26 11:33, Alice Ryhl wrote: > > On Mon, Mar 02, 2026 at 11:27:40AM +0100, David Hildenbrand (Arm) wrote: > >> On 3/2/26 11:01, Alice Ryhl wrote: > >>> > >>> Well, rustfmt comes with the compiler, and it would be ideal to build > >>> test changes before sending them :) > >> > >> At least on Ubuntu on my notebook where I do most of the coding+patch > >> submissions it's a separate package? > >> > >> I do all my builds on a different (more powerful) machine where the > >> whole rust machinery's in place. Further, build bots that run on my > >> private branches did not report any issues. > > > > There are some build bots that check for rustfmt, though not all of > > them. > > > >>> But no worries, I took care of testing it. Thanks for taking the time to > >>> update the Rust code as well. > >> > >> I just did an allyesconfig and it does not report any warnings. > >> > >> So apparently, rustfmt problems not result in the compiler complaining? > >> > >> Or something else is off here that rust/kernel/mm/virt.rs won't get > >> compiled on my machine, even with allyesconfig. I can definitely see > >> some RUSTC stuff happening in the logs, like > >> > >> RUSTC L rust/kernel.o > >> > >> Thanks for the review and for pointing out rustfmt! > > > > Similar to kerneldoc and other similar targets, formatting isn't checked > > in the normal build, but make can be invoked on the rustfmtcheck target > > to check it. > > Thanks adding that to my cross-compile chain. Awesome, thanks! It's not relevant in this patch, but another thing that may be useful is to add CLIPPY=1 to the make invocation when building normally. This causes additional warnings to be checked using a tool called clippy. Alice