From: Timur Tabi <timur@kernel.org>
To: "S.j. Wang" <shengjiu.wang@nxp.com>,
"nicoleotsuka@gmail.com" <nicoleotsuka@gmail.com>,
"Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] ASoC: cs42xx8: Remove S32_LE in format list
Date: Thu, 28 Feb 2019 08:33:37 -0600 [thread overview]
Message-ID: <ab0a0d6c-4905-328c-0e22-931c045ed8d9@kernel.org> (raw)
In-Reply-To: <1551333389-22791-1-git-send-email-shengjiu.wang@nxp.com>
On 2/27/19 11:56 PM, S.j. Wang wrote:
> cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE
> should not be in the supported format list.
>
> Signed-off-by: Shengjiu Wang<shengjiu.wang@nxp.com>
Is the device capable of accepting 32-bit samples, even if it downgrades
it to 24-bit internally? If so, then maybe SNDRV_PCM_FMTBIT_S32_LE
should stay.
next prev parent reply other threads:[~2019-02-28 14:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 5:56 [PATCH] ASoC: cs42xx8: Remove S32_LE in format list S.j. Wang
2019-02-28 14:33 ` Timur Tabi [this message]
2019-03-01 3:45 ` S.j. Wang
2019-03-01 4:50 ` Nicolin Chen
2019-03-01 5:04 ` [alsa-devel] " Matt Flax
2019-03-01 6:32 ` S.j. Wang
2019-03-01 14:32 ` Timur Tabi
2019-03-02 5:42 ` S.j. Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0a0d6c-4905-328c-0e22-931c045ed8d9@kernel.org \
--to=timur@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).