From: Milton Miller <miltonm@bga.com>
To: Scott Wood <scottwood@freescale.com>
Cc: ppcdev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 2/9] bootwrapper: Add strtoull().
Date: Thu, 30 Aug 2007 10:52:22 -0500 [thread overview]
Message-ID: <ab107db1fd4d7e9bc3b461b7f4157100@bga.com> (raw)
In-Reply-To: <20070829164638.GA31640@ld0162-tx32.am.freescale.net>
On Thu Aug 30 02:46:38 EST 2007, Scott Wood wrote:
> + if (*ptr >= '0' && *ptr <= '9' && *ptr < '0' + base)
> + digit = *ptr - '0';
> + else if (*ptr >= 'A' && *ptr < 'A' + base - 10)
> + digit = *ptr - 'A' + 10;
> + else if (*ptr >= 'a' && *ptr < 'z' + base - 10)
> + digit = *ptr - 'a' + 10;
> + else
> + break;
'z' should also be 'a' like the 'A' case.
Should we add <= 'Z' like we do '9', or do we not care about bases >
36? (It really breaks above base 42).
milton
next prev parent reply other threads:[~2007-08-30 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 16:45 [PATCH 1/9] bootwrapper: flatdevtree fixes Scott Wood
2007-08-29 16:46 ` [PATCH 2/9] bootwrapper: Add strtoull() Scott Wood
2007-08-30 0:30 ` David Gibson
2007-08-30 15:52 ` Milton Miller [this message]
2007-08-30 16:16 ` Scott Wood
2007-08-29 16:46 ` [PATCH 3/9] bootwrapper: Add get_path() Scott Wood
2007-08-30 0:30 ` David Gibson
2007-08-29 16:47 ` [PATCH 4/9] bootwrapper: Move strncmp() from flatdevtree_env.h to string.S/string.h Scott Wood
2007-08-30 0:31 ` David Gibson
2007-08-29 16:47 ` [PATCH 6/9] bootwrapper: Add a zImage.bin.<platform> target Scott Wood
2007-08-30 0:34 ` David Gibson
2007-08-30 14:21 ` Scott Wood
2007-08-31 3:24 ` David Gibson
2007-08-29 16:47 ` [PATCH 7/9] bootwrapper: Only print MAC addresses when the node is actually present Scott Wood
2007-08-30 0:34 ` David Gibson
2007-08-29 16:47 ` [PATCH 8/9] bootwrapper: Add fsl_get_immr() and 8xx/pq2 clock functions Scott Wood
2007-08-29 16:47 ` [PATCH 9/9] bootwrapper: Use fsl_get_immr() in cuboot-pq2.c Scott Wood
2007-08-30 0:28 ` [PATCH 1/9] bootwrapper: flatdevtree fixes David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab107db1fd4d7e9bc3b461b7f4157100@bga.com \
--to=miltonm@bga.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).