* [PATCH] ocxl: do not use C++ style comments in uapi header
@ 2019-06-04 11:16 Masahiro Yamada
2019-06-04 11:51 ` Frederic Barrat
2019-06-15 13:36 ` Michael Ellerman
0 siblings, 2 replies; 6+ messages in thread
From: Masahiro Yamada @ 2019-06-04 11:16 UTC (permalink / raw)
To: Frederic Barrat, Andrew Donnellan, linuxppc-dev
Cc: Arnd Bergmann, Greg KH, Randy Dunlap, linux-kernel,
Masahiro Yamada, Joe Perches, Thomas Gleixner
Linux kernel tolerates C++ style comments these days. Actually, the
SPDX License tags for .c files start with //.
On the other hand, uapi headers are written in more strict C, where
the C++ comment style is forbidden.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
include/uapi/misc/ocxl.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/uapi/misc/ocxl.h b/include/uapi/misc/ocxl.h
index 97937cfa3baa..6d29a60a896a 100644
--- a/include/uapi/misc/ocxl.h
+++ b/include/uapi/misc/ocxl.h
@@ -33,23 +33,23 @@ struct ocxl_ioctl_attach {
};
struct ocxl_ioctl_metadata {
- __u16 version; // struct version, always backwards compatible
+ __u16 version; /* struct version, always backwards compatible */
- // Version 0 fields
+ /* Version 0 fields */
__u8 afu_version_major;
__u8 afu_version_minor;
- __u32 pasid; // PASID assigned to the current context
+ __u32 pasid; /* PASID assigned to the current context */
- __u64 pp_mmio_size; // Per PASID MMIO size
+ __u64 pp_mmio_size; /* Per PASID MMIO size */
__u64 global_mmio_size;
- // End version 0 fields
+ /* End version 0 fields */
- __u64 reserved[13]; // Total of 16*u64
+ __u64 reserved[13]; /* Total of 16*u64 */
};
struct ocxl_ioctl_p9_wait {
- __u16 thread_id; // The thread ID required to wake this thread
+ __u16 thread_id; /* The thread ID required to wake this thread */
__u16 reserved1;
__u32 reserved2;
__u64 reserved3[3];
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ocxl: do not use C++ style comments in uapi header
2019-06-04 11:16 [PATCH] ocxl: do not use C++ style comments in uapi header Masahiro Yamada
@ 2019-06-04 11:51 ` Frederic Barrat
2019-06-04 12:12 ` Masahiro Yamada
2019-06-15 13:36 ` Michael Ellerman
1 sibling, 1 reply; 6+ messages in thread
From: Frederic Barrat @ 2019-06-04 11:51 UTC (permalink / raw)
To: Masahiro Yamada, Andrew Donnellan, linuxppc-dev
Cc: Arnd Bergmann, Greg KH, Randy Dunlap, linux-kernel, Joe Perches,
Thomas Gleixner
Le 04/06/2019 à 13:16, Masahiro Yamada a écrit :
> Linux kernel tolerates C++ style comments these days. Actually, the
> SPDX License tags for .c files start with //.
>
> On the other hand, uapi headers are written in more strict C, where
> the C++ comment style is forbidden.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Thanks!
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
>
> include/uapi/misc/ocxl.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/include/uapi/misc/ocxl.h b/include/uapi/misc/ocxl.h
> index 97937cfa3baa..6d29a60a896a 100644
> --- a/include/uapi/misc/ocxl.h
> +++ b/include/uapi/misc/ocxl.h
> @@ -33,23 +33,23 @@ struct ocxl_ioctl_attach {
> };
>
> struct ocxl_ioctl_metadata {
> - __u16 version; // struct version, always backwards compatible
> + __u16 version; /* struct version, always backwards compatible */
>
> - // Version 0 fields
> + /* Version 0 fields */
> __u8 afu_version_major;
> __u8 afu_version_minor;
> - __u32 pasid; // PASID assigned to the current context
> + __u32 pasid; /* PASID assigned to the current context */
>
> - __u64 pp_mmio_size; // Per PASID MMIO size
> + __u64 pp_mmio_size; /* Per PASID MMIO size */
> __u64 global_mmio_size;
>
> - // End version 0 fields
> + /* End version 0 fields */
>
> - __u64 reserved[13]; // Total of 16*u64
> + __u64 reserved[13]; /* Total of 16*u64 */
> };
>
> struct ocxl_ioctl_p9_wait {
> - __u16 thread_id; // The thread ID required to wake this thread
> + __u16 thread_id; /* The thread ID required to wake this thread */
> __u16 reserved1;
> __u32 reserved2;
> __u64 reserved3[3];
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ocxl: do not use C++ style comments in uapi header
2019-06-04 11:51 ` Frederic Barrat
@ 2019-06-04 12:12 ` Masahiro Yamada
2019-06-05 6:16 ` Andrew Donnellan
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2019-06-04 12:12 UTC (permalink / raw)
To: Frederic Barrat
Cc: Andrew Donnellan, Arnd Bergmann, Greg KH, Randy Dunlap,
Linux Kernel Mailing List, Joe Perches, Thomas Gleixner,
linuxppc-dev
On Tue, Jun 4, 2019 at 8:54 PM Frederic Barrat <fbarrat@linux.ibm.com> wrote:
>
>
>
> Le 04/06/2019 à 13:16, Masahiro Yamada a écrit :
> > Linux kernel tolerates C++ style comments these days. Actually, the
> > SPDX License tags for .c files start with //.
> >
> > On the other hand, uapi headers are written in more strict C, where
> > the C++ comment style is forbidden.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
>
> Thanks!
> Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
>
Please hold on this patch until
we get consensus about the C++ comment style.
Discussion just started here:
https://lore.kernel.org/patchwork/patch/1083801/
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ocxl: do not use C++ style comments in uapi header
2019-06-04 12:12 ` Masahiro Yamada
@ 2019-06-05 6:16 ` Andrew Donnellan
2019-06-06 9:00 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Donnellan @ 2019-06-05 6:16 UTC (permalink / raw)
To: Masahiro Yamada, Frederic Barrat
Cc: Arnd Bergmann, Greg KH, Randy Dunlap, Linux Kernel Mailing List,
Joe Perches, Thomas Gleixner, linuxppc-dev
On 4/6/19 10:12 pm, Masahiro Yamada wrote:
> On Tue, Jun 4, 2019 at 8:54 PM Frederic Barrat <fbarrat@linux.ibm.com> wrote:
>>
>>
>>
>> Le 04/06/2019 à 13:16, Masahiro Yamada a écrit :
>>> Linux kernel tolerates C++ style comments these days. Actually, the
>>> SPDX License tags for .c files start with //.
>>>
>>> On the other hand, uapi headers are written in more strict C, where
>>> the C++ comment style is forbidden.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> ---
>>
>> Thanks!
>> Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
>>
>
> Please hold on this patch until
> we get consensus about the C++ comment style.
>
> Discussion just started here:
> https://lore.kernel.org/patchwork/patch/1083801/
If you choose to proceed with this patch:
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ocxl: do not use C++ style comments in uapi header
2019-06-05 6:16 ` Andrew Donnellan
@ 2019-06-06 9:00 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2019-06-06 9:00 UTC (permalink / raw)
To: linuxppc-dev, Michael Ellerman
Cc: Andrew Donnellan, Arnd Bergmann, Greg KH, Randy Dunlap,
Linux Kernel Mailing List, Joe Perches, Frederic Barrat,
Thomas Gleixner
Hi Michael,
On Wed, Jun 5, 2019 at 3:18 PM Andrew Donnellan <ajd@linux.ibm.com> wrote:
>
> On 4/6/19 10:12 pm, Masahiro Yamada wrote:
> > On Tue, Jun 4, 2019 at 8:54 PM Frederic Barrat <fbarrat@linux.ibm.com> wrote:
> >>
> >>
> >>
> >> Le 04/06/2019 à 13:16, Masahiro Yamada a écrit :
> >>> Linux kernel tolerates C++ style comments these days. Actually, the
> >>> SPDX License tags for .c files start with //.
> >>>
> >>> On the other hand, uapi headers are written in more strict C, where
> >>> the C++ comment style is forbidden.
> >>>
> >>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >>> ---
> >>
> >> Thanks!
> >> Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> >>
> >
> > Please hold on this patch until
> > we get consensus about the C++ comment style.
> >
> > Discussion just started here:
> > https://lore.kernel.org/patchwork/patch/1083801/
>
> If you choose to proceed with this patch:
>
> Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
After some discussion,
the other one was applied to the media subsystem.
Please pick up this one with Frederic and Andrew's Ack.
Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ocxl: do not use C++ style comments in uapi header
2019-06-04 11:16 [PATCH] ocxl: do not use C++ style comments in uapi header Masahiro Yamada
2019-06-04 11:51 ` Frederic Barrat
@ 2019-06-15 13:36 ` Michael Ellerman
1 sibling, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2019-06-15 13:36 UTC (permalink / raw)
To: Masahiro Yamada, Frederic Barrat, Andrew Donnellan, linuxppc-dev
Cc: Arnd Bergmann, Greg KH, Randy Dunlap, linux-kernel,
Masahiro Yamada, Joe Perches, Thomas Gleixner
On Tue, 2019-06-04 at 11:16:32 UTC, Masahiro Yamada wrote:
> Linux kernel tolerates C++ style comments these days. Actually, the
> SPDX License tags for .c files start with //.
>
> On the other hand, uapi headers are written in more strict C, where
> the C++ comment style is forbidden.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/2305ff225c0b1691ec2e93f3d6990e13
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-15 13:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04 11:16 [PATCH] ocxl: do not use C++ style comments in uapi header Masahiro Yamada
2019-06-04 11:51 ` Frederic Barrat
2019-06-04 12:12 ` Masahiro Yamada
2019-06-05 6:16 ` Andrew Donnellan
2019-06-06 9:00 ` Masahiro Yamada
2019-06-15 13:36 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).