From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: Diana Craciun <diana.craciun@nxp.com>,
Scott Wood <oss@buserror.net>, Nick Piggin <npiggin@au1.ibm.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: Re: [RFC/WIP] powerpc: Fix 32-bit handling of MSR_EE on exceptions
Date: Fri, 21 Dec 2018 09:35:16 +1100 [thread overview]
Message-ID: <ab9139902a64f8d0b187f7db0f8a16a5b85791ac.camel@kernel.crashing.org> (raw)
In-Reply-To: <cbce315b-82f9-c748-92e4-97bb819c9098@c-s.fr>
> > /*
> > * MSR_KERNEL is > 0x10000 on 4xx/Book-E since it include MSR_CE.
> > @@ -205,20 +208,46 @@ transfer_to_handler_cont:
> > mflr r9
> > lwz r11,0(r9) /* virtual address of handler */
> > lwz r9,4(r9) /* where to go when done */
> > +#if defined(CONFIG_PPC_8xx) && defined(CONFIG_PERF_EVENTS)
> > + mtspr SPRN_NRI, r0
> > +#endif
>
> That's not part of your patch, it's already in the tree.
Yup rebase glitch.
.../...
> I tested it on the 8xx with the below changes in addition. No issue seen
> so far.
Thanks !
I'll merge that in.
The main obscure area is that business with the irqsoff tracer and thus
the need to create stack frames around calls to trace_hardirqs_* ... we
do it in some places and not others, but I've not managed to make it
crash either. I need to get to the bottom of that, and possibly provide
proper macro helpers like ppc64 has to do it.
Cheers,
Ben.
next prev parent reply other threads:[~2018-12-20 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 5:40 [RFC/WIP] powerpc: Fix 32-bit handling of MSR_EE on exceptions Benjamin Herrenschmidt
2018-12-20 16:33 ` Christophe Leroy
2018-12-20 22:35 ` Benjamin Herrenschmidt [this message]
2019-02-05 9:45 ` Christophe Leroy
2019-02-05 10:10 ` Michael Ellerman
2019-03-15 17:10 ` Christophe Leroy
2019-02-05 12:19 ` Benjamin Herrenschmidt
2019-01-27 18:56 ` christophe leroy
2019-01-27 19:26 ` christophe leroy
2019-02-05 12:14 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab9139902a64f8d0b187f7db0f8a16a5b85791ac.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=diana.craciun@nxp.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@au1.ibm.com \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).