From: Sathvika Vasireddy <sv@linux.ibm.com>
To: Kautuk Consul <kconsul@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] arch/powerpc/kvm: kvmppc_hv_entry: remove .global scope
Date: Fri, 24 Feb 2023 16:45:45 +0530 [thread overview]
Message-ID: <acb32fb3-c674-25fa-d6de-bcb6a4ce8f46@linux.ibm.com> (raw)
In-Reply-To: <Y/b1Hpk8rhrR+H9I@li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com>
On 23/02/23 10:39, Kautuk Consul wrote:
> Hi Sathvika,
>> Just one question though. Went through the code again and I think
>> that this place shouldn't be proper to insert a SYM_FUNC_END
>> because we haven't entered the guest at this point and the name
>> of the function is kvmppc_hv_entry which I think implies that
>> this SYM_FUNC_END should be at some place after the HRFI_TO_GUEST.
>>
>> What do you think ?
> Any updates on this ? Is there any other way to avoid this warning ?
Hmm, to mark the end of the kvmppc_hv_entry function, I think
SYM_FUNC_END(kvmppc_hv_entry) should be placed before the next symbol,
which is kvmppc_got_guest() in this case.
However, if you think it needs to be put at a different place, then it
does not make sense to have any other symbols before that. You may want
to consider checking if other macros like SYM_INNER_LABEL() can be used.
- Sathvika
next prev parent reply other threads:[~2023-02-24 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 5:23 [PATCH 0/2] Improving calls to kvmppc_hv_entry Kautuk Consul
2023-02-20 5:23 ` [PATCH 1/2] arch/powerpc/kvm: kvmppc_hv_entry: remove .global scope Kautuk Consul
2023-02-20 7:05 ` Sathvika Vasireddy
2023-02-20 7:28 ` Kautuk Consul
2023-02-20 8:01 ` Sathvika Vasireddy
2023-02-20 8:11 ` Kautuk Consul
2023-02-20 9:17 ` Kautuk Consul
2023-02-23 5:09 ` Kautuk Consul
2023-02-24 11:15 ` Sathvika Vasireddy [this message]
2023-03-06 12:22 ` Kautuk Consul
2023-02-20 5:23 ` [PATCH 2/2] arch/powerpc/kvm: kvmppc_hv_entry: remove r4 argument Kautuk Consul
2023-03-06 12:24 ` Kautuk Consul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acb32fb3-c674-25fa-d6de-bcb6a4ce8f46@linux.ibm.com \
--to=sv@linux.ibm.com \
--cc=kconsul@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).