From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.191]) by ozlabs.org (Postfix) with ESMTP id 4B1B467B9B for ; Wed, 1 Nov 2006 21:48:21 +1100 (EST) Received: by nf-out-0910.google.com with SMTP id x4so558036nfb for ; Wed, 01 Nov 2006 02:48:19 -0800 (PST) Message-ID: Date: Wed, 1 Nov 2006 13:48:19 +0300 From: "Vitaly Wool" To: "Andy Fleming" Subject: Re: [PATCH] Fix oprofile support for e500 in arch/powerpc In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: Cc: linuxppc-dev@ozlabs.org, Paul Mackerras , Oprofile List , linuxppc-embedded List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/27/06, Andy Fleming wrote: > Fixed a compile error in building the 85xx support with oprofile, and in > the process cleaned up some issues with the fsl_booke performance monitor > code. > > * Reorganized FSL Book-E performance monitoring code so that the 7450 > wouldn't be built if the e500 was, and cleaned it up so it was more > self-contained. > > * Added a cpu_setup function for FSL Book-E. The original > cpu_setup function prototype had no arguments, assuming that > the reg_setup function would copy the required information into > variables which represented the registers. This was silly for > e500, since it has 1 register per counter (rather than 3 for > all counters), so the code has been restructured to have > cpu_setup take the current counter config array as an argument, > with op_powerpc_setup() invoking op_powerpc_cpu_setup() through > on_each_cpu(), and op_powerpc_cpu_setup() invoking the > model-specific cpu_setup function with an argument. The > argument is ignored on all other platforms at present. > > * Fixed a confusing line where a trinary operator only had two > arguments > Signed-off-by: Andrew Fleming I'm pretty comfortable with this one, waiting for it to appear in the powerpc git tree... Vitaly