From: "Vitaly Wool" <vitalywool@gmail.com>
To: joakim.tjernlund@transmode.se
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Adapt spi_mpc83xx SPI driver for 832x
Date: Wed, 13 Dec 2006 12:44:19 +0300 [thread overview]
Message-ID: <acd2a5930612130144u2d75229etecb82611b0bea04a@mail.gmail.com> (raw)
In-Reply-To: <1166001747.30422.43.camel@gentoo-jocke.transmode.se>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
On 12/13/06, Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote:
>
> The MPC 832x has a different SPI controller i/f, probably due to
> its QUICC engine support. This patch adapts the spi_mpx83xx driver to
> be usable on QE based 83xx cpus.
>
First, I'm pretty much against sending such patches to arch lists and not to
subsystem lists.
@@ -99,31 +105,39 @@ static inline u32 mpc83xx_spi_read_reg(_
return in_be32(reg);
}
Then, this
+ *rx++ = (type)(data >> shift); \
and this
+ data = *tx++ << shift; \
pieces of code are potentially dangerous (what if 'shift' is something like
'x & 0xf3 << 4' ?)
Vitaly
[-- Attachment #2: Type: text/html, Size: 1495 bytes --]
next prev parent reply other threads:[~2006-12-13 9:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 9:22 [PATCH] Adapt spi_mpc83xx SPI driver for 832x Joakim Tjernlund
2006-12-13 9:44 ` Vitaly Wool [this message]
2006-12-13 9:53 ` Li Yang-r58472
2006-12-13 14:46 ` Kumar Gala
2006-12-13 15:36 ` Joakim Tjernlund
2006-12-13 20:31 ` [spi-devel-general] " David Brownell
2006-12-14 0:13 ` Joakim Tjernlund
2006-12-14 5:54 ` Kumar Gala
2006-12-14 10:02 ` Joakim Tjernlund
2006-12-14 19:59 ` Reeve Yang
2006-12-14 20:12 ` Ben Warren
2006-12-14 20:39 ` Reeve Yang
2006-12-14 21:30 ` Ben Warren
2006-12-23 1:09 ` David Brownell
2006-12-26 16:31 ` Kumar Gala
2007-02-17 2:17 ` David Brownell
2007-02-17 9:14 ` Joakim Tjernlund
2006-12-23 0:57 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2006-12-13 9:59 Joakim Tjernlund
2006-12-13 10:05 Joakim Tjernlund
2006-12-13 10:45 ` Vitaly Wool
2006-12-13 12:22 Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acd2a5930612130144u2d75229etecb82611b0bea04a@mail.gmail.com \
--to=vitalywool@gmail.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).