On 12/13/06, <b class="gmail_sendername">Joakim Tjernlund</b> &lt;<a href="mailto:joakim.tjernlund@transmode.se">joakim.tjernlund@transmode.se</a>&gt; wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
The MPC 832x has a different SPI controller i/f, probably due to<br>its QUICC engine support. This patch adapts the spi_mpx83xx driver to<br>be usable on QE based 83xx cpus.<br></blockquote></div><br>First, I'm pretty much against sending such patches to arch lists and not to subsystem lists.
<br><br>@@ -99,31 +105,39 @@ static inline u32 mpc83xx_spi_read_reg(_<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return in_be32(reg);<br>&nbsp;}<br><br>Then,&nbsp; this <br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; *rx++ = (type)(data &gt;&gt; shift);&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>and this
<br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; data = *tx++ &lt;&lt; shift;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br><br>pieces of code are potentially dangerous (what if 'shift' is something like 'x &amp; 0xf3 &lt;&lt; 4' ?)<br><br>Vitaly<br>