From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4A3CC5479D for ; Mon, 9 Jan 2023 11:46:02 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NrBwT2gQMz3fDR for ; Mon, 9 Jan 2023 22:46:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.128.45; helo=mail-wm1-f45.google.com; envelope-from=jirislaby@gmail.com; receiver=) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Nr6gc5b9Nz304m for ; Mon, 9 Jan 2023 19:34:35 +1100 (AEDT) Received: by mail-wm1-f45.google.com with SMTP id i17-20020a05600c355100b003d99434b1cfso5990356wmq.1 for ; Mon, 09 Jan 2023 00:34:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ai89XU1vTr8jmWYzTC3dz44+t98FTx9wn3aEaRiaIuk=; b=Xbq63OKVQLAjNmZU4CWzY2YB5T288OxyNTkCG3/PyITGs/90hOC46E6PfMIsvnuKER e9fYQb9MhP95HG4lRweS2rAUsafkmyEsNVHwyIexS8k8H7OGqUOfsJaVeKJkgI8k4iqz K65bhroODog2AbilUnzqrMspb2iRU+b2Jys/ZSqd79O67+4g9aTzmAw6IIwuPVk4HP25 SN79DcJeThhtsrr0ug6woSHg9bhb5vTZw6Au0x5rZpvkD+yg5y/wxJs40X+p9ltAnzH/ DumC+Hx4tPUqFKdfc75JMxCeZ9m31MeqRD208wqfkTRr1rIo8r8/gjlY44+Z9pVgZ4MG 0fZA== X-Gm-Message-State: AFqh2krHR1gmww2UE3rHh5tauJWZ7DjN2T5/qomrOhpQ3QP8FSX6I/W6 huP/e5r1n8SFY4uOk/bJEys= X-Google-Smtp-Source: AMrXdXtjlHdY/ENv0HKrQhiUW86lNsmrAe9U9q9o1ZJzBphFcyOOuX1i4xq4T+O9/Z+J1SnbwUA6Kw== X-Received: by 2002:a05:600c:1da3:b0:3d0:965f:63ed with SMTP id p35-20020a05600c1da300b003d0965f63edmr46049641wms.23.1673253271256; Mon, 09 Jan 2023 00:34:31 -0800 (PST) Received: from [192.168.1.49] (185-219-167-24-static.vivo.cz. [185.219.167.24]) by smtp.gmail.com with ESMTPSA id l27-20020a05600c2cdb00b003a84375d0d1sm16068925wmc.44.2023.01.09.00.34.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 00:34:30 -0800 (PST) Message-ID: Date: Mon, 9 Jan 2023 09:34:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH net-next] Remove DECnet support from kernel Content-Language: en-US To: Jan Engelhardt References: <20220818004357.375695-1-stephen@networkplumber.org> <07786498-2209-3af0-8d68-c34427049947@kernel.org> From: Jiri Slaby In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 09 Jan 2023 22:45:00 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:NETFILTER" , "open list:DOCUMENTATION" , Jeff Layton , Nikolay Aleksandrov , "open list:MIPS" , Wang Qing , Paul Gortmaker , Eric Dumazet , Nathan Fontenot , Suma Hegde , Paolo Abeni , Neeraj Upadhyay , Menglong Dong , Florian Fainelli , Xin Long , Chen Yu , Daniel Borkmann , Jonathan Corbet , Damien Le Moal , Jozsef Kadlecsik , Xie Yongji , "open list:NETFILTER" , Roopa Prabhu , Jakub Kicinski , Borislav Petkov , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Stefano Garzarella , Petr Machata , "open list:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" , Kees Cook , "Paul E. McKenney" , Yu Zhe , William Breathitt Gray , Nicholas Piggin , Hans de Goede , Kuniyuki Iwashima , Shakeel Butt , Muchun Song , Alexandre Ghiti , Yuwei Wang , Juergen Gross , Thomas Bogendoerfer , Akhmat Karakotov , "Martin K. Petersen" , netdev@vger.kernel.org, David Ahern , Randy Dunlap , Florian Westphal , open list < linux-kernel@vger.kernel.org>, Stephen Hemminger , Chuck Lever , Arnd Bergmann , Antoine Tenart , Andrew Morton , =?UTF-8?Q?Pali_Roh=c3=a1r?= , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 09. 01. 23, 9:14, Jan Engelhardt wrote: > > On Monday 2023-01-09 08:04, Jiri Slaby wrote: >> On 18. 08. 22, 2:43, Stephen Hemminger wrote: >>> DECnet is an obsolete network protocol >> >> this breaks userspace. Some projects include linux/dn.h: >> >> https://codesearch.debian.net/search?q=include.*linux%2Fdn.h&literal=0 >> >> I found Trinity fails to build: >> net/proto-decnet.c:5:10: fatal error: linux/dn.h: No such file or directory >> 5 | #include >> >> Should we provide the above as empty files? > > Not a good idea. There may be configure tests / code that merely checks for > dn.h existence without checking for specific contents/defines. If you provide > empty files, this would fail to build: > > #include "config.h" > #ifdef HAVE_LINUX_DN_H > # include > #endif > int main() { > #ifdef HAVE_LINUX_DN_H > socket(AF_DECNET, 0, DNPROTO_NSP); // or whatever > #else > ... > #endif > } > > So, with my distro hat on, outright removing header files feels like the > slightly lesser of two evils. Given the task to port $arbitrary software > between operating systems, absent header files is something more or less > "regularly" encountered, so one could argue we are "trained" to deal with it. > But missing individual defines is a much deeper dive into the APIs and > software to patch it out. Right, we used to keep providing also defines and structs in uapi headers of removed functionality. So that the above socket would compile, but fail during runtime. I am not biased to any solution. In fact, I found out trinity was fixed already. So either path networking takes, it's fine by me. I'm not sure about the chromium users, though (and I don't care). thanks, -- js suse labs