From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Keith Busch <kbusch@kernel.org>,
Oliver O'Halloran <oohall@gmail.com>,
Dongdong Liu <liudongdong3@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/1] PCI/DPC: Fix TLP Prefix register reading offset
Date: Mon, 22 Jan 2024 14:20:25 +0200 (EET) [thread overview]
Message-ID: <ad91677a-cce3-03fe-c826-12f8d44e3466@linux.intel.com> (raw)
In-Reply-To: <20240119225923.GA191511@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Fri, 19 Jan 2024, Bjorn Helgaas wrote:
> On Thu, Jan 18, 2024 at 01:08:15PM +0200, Ilpo Järvinen wrote:
> > The TLP Prefix Log Register consists of multiple DWORDs (PCIe r6.1 sec
> > 7.9.14.13) but the loop in dpc_process_rp_pio_error() keeps reading
> > from the first DWORD. Add the iteration count based offset calculation
> > into the config read.
>
> So IIUC the user-visible bug is that we print only the first PIO TLP
> Prefix (duplicated several times), and we never print the second,
> third, etc Prefixes, right?
Yes.
> I wish we could print them all in a single pci_err(), as we do for the
> TLP Header Log, instead of dribbling them out one by one.
I've also done some work towards consolidating AER and DPC TLP
Header/Prefix Log handling which is when I found this bug (the reading
side is already done but printing is still pending).
> > Fixes: f20c4ea49ec4 ("PCI/DPC: Add eDPC support")
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-01-22 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 11:08 [PATCH 1/1] PCI/DPC: Fix TLP Prefix register reading offset Ilpo Järvinen
2024-01-19 22:59 ` Bjorn Helgaas
2024-01-22 12:20 ` Ilpo Järvinen [this message]
2024-01-22 18:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad91677a-cce3-03fe-c826-12f8d44e3466@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liudongdong3@huawei.com \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).