linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Eli Cohen <eli@mellanox.co.il>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: FW: [PATCH] powerpc/mm: Export HPAGE_SHIFT
Date: Tue, 03 Feb 2009 17:08:54 -0800	[thread overview]
Message-ID: <ada8wonnh3t.fsf@cisco.com> (raw)
In-Reply-To: <20090203164930.GA10101@mtls03> (Eli Cohen's message of "Tue, 3 Feb 2009 18:49:30 +0200")

Forwarding Eli's patch below, since PowerPC guys may have missed it.  I
guess the question for Ben et al is whether there is any issue with
exporting HPAGE_SHIFT for modules (can be EXPORT_SYMBOL_GPL if you feel
it's an internal detail).  It would probably make sense to roll this
change into the mlx4 change that Eli alludes to below and merge through
my tree (with ppc maintainer acks of course), rather than splitting this
patch out and introducing cross-tree dependencies (and also separating
the rationale for the change from the change itself).

Thanks,
  Roland


Drivers may want to take advantage of the large pages used for memory obtained
from hugetlbfs. One example is mlx4_ib which can use much less MTT entries (in
the order of HPAGE_SIZE / PAGE_SIZE) when registering such memory, thus scale
significantly better when registering larger memory regions. Other drivers
could also benefit from this.

Signed-off-by: Eli Cohen <eli@mellanox.co.il>
---
 arch/powerpc/mm/hash_utils_64.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 8d5b475..6cff8c7 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -104,6 +104,7 @@ int mmu_highuser_ssize = MMU_SEGSIZE_256M;
 u16 mmu_slb_size = 64;
 #ifdef CONFIG_HUGETLB_PAGE
 unsigned int HPAGE_SHIFT;
+EXPORT_SYMBOL(HPAGE_SHIFT);
 #endif
 #ifdef CONFIG_PPC_64K_PAGES
 int mmu_ci_restrictions;
-- 
1.6.1

       reply	other threads:[~2009-02-04  1:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090203164930.GA10101@mtls03>
2009-02-04  1:08 ` Roland Dreier [this message]
2009-02-04  1:50   ` FW: [PATCH] powerpc/mm: Export HPAGE_SHIFT Benjamin Herrenschmidt
2009-02-04  5:13     ` Andrew Morton
2009-02-04  5:31       ` Nick Piggin
2009-02-04  6:17         ` wli
2009-02-04  6:16       ` Roland Dreier
2009-02-04  6:26         ` Andrew Morton
2009-02-04 19:11           ` Roland Dreier
2009-02-04 21:00             ` wli
2009-02-04 21:31               ` Roland Dreier
2009-02-04 21:23             ` Andrew Morton
2009-02-04 23:55             ` Benjamin Herrenschmidt
2009-02-05  5:10               ` Roland Dreier
2009-02-05  5:24                 ` Benjamin Herrenschmidt
2009-02-05  5:33                   ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada8wonnh3t.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=benh@kernel.crashing.org \
    --cc=eli@mellanox.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).